Skip to content

Commit 9603d9f

Browse files
vishalshrm539Vishaltumms2021389
authored
Replace the existing Phone comp with mui-tel-input (#415)
Co-authored-by: Vishal <[email protected]> Co-authored-by: tumms2021389 <[email protected]>
1 parent 0f9e817 commit 9603d9f

File tree

4 files changed

+40
-36
lines changed

4 files changed

+40
-36
lines changed

package-lock.json

Lines changed: 31 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"downloadjs": "^1.4.7",
6363
"fast-deep-equal": "^3.1.3",
6464
"lodash.difference": "^4.5.0",
65-
"material-ui-phone-number": "^3.0.0",
65+
"mui-tel-input": "^6.0.1",
6666
"react": "^17.0.2",
6767
"react-datepicker": "^4.25.0",
6868
"react-dom": "^17.0.2",

packages/react-sdk-components/src/components/field/Phone/Phone.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useEffect, useState } from 'react';
2-
import MuiPhoneNumber from 'material-ui-phone-number';
2+
import { MuiTelInput } from 'mui-tel-input';
33

44
import { getComponentFromMap } from '../../../bridge/helpers/sdk_component_map';
55
import { PConnFieldProps } from '../../../types/PConnProps';
@@ -57,12 +57,12 @@ export default function Phone(props: PhoneProps) {
5757
const disableDropdown = true;
5858
return (
5959
<div>
60-
<MuiPhoneNumber
60+
<MuiTelInput
6161
fullWidth
6262
helperText={helperTextToDisplay}
6363
placeholder={placeholder ?? ''}
6464
size='small'
65-
defaultCountry='us'
65+
defaultCountry='US'
6666
required={required}
6767
disabled={disabled}
6868
onChange={onChange}
@@ -91,13 +91,13 @@ export default function Phone(props: PhoneProps) {
9191
};
9292

9393
return (
94-
<MuiPhoneNumber
94+
<MuiTelInput
9595
fullWidth
9696
variant='outlined'
9797
helperText={helperTextToDisplay}
9898
placeholder={placeholder ?? ''}
9999
size='small'
100-
defaultCountry='us'
100+
defaultCountry='US'
101101
required={required}
102102
disabled={disabled}
103103
onChange={handleChange}

packages/react-sdk-components/tests/e2e/Digv2/FormFields/Phone.spec.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,16 @@ test.describe('E2E test', () => {
9999
const validationMsg = 'Enter a valid phone number';
100100
await editablePhoneInput.clear();
101101
await countrySelector.click();
102-
await page.locator('text=United States+1 >> nth=0').click();
102+
await page.locator('text=United Kingdom+44 >> nth=0').click();
103103
/** Entering an invalid Phone number */
104104
await common.enterPhoneNumber(editablePhone, '61');
105105
await editablePhoneInput.blur();
106106
/** Expecting an error for Invalid phone number */
107+
107108
await expect(page.locator(`p:has-text("${validationMsg}")`)).toBeVisible();
108109

109110
/** Entering a valid Phone number */
111+
await editablePhoneInput.click();
110112
await editablePhoneInput.clear();
111113
await countrySelector.click();
112114
await page.locator('text=United States+1 >> nth=0').click();

0 commit comments

Comments
 (0)