Skip to content

Commit afe1106

Browse files
authored
Merge branch 'master' into mod/tor/US-650250
2 parents 6d59cdb + 0f9e817 commit afe1106

File tree

5 files changed

+16
-7
lines changed

5 files changed

+16
-7
lines changed

packages/react-sdk-components/src/components/infra/Containers/FlowContainer/FlowContainer.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,9 @@ export const FlowContainer = (props: FlowContainerProps) => {
266266
// if have caseMessage show message and end
267267
const theCaseMessages = localizedVal(thePConn.getValue('caseMessages', ''), localeCategory); // 2nd arg empty string until typedefs properly allow optional
268268

269-
if (theCaseMessages || !hasAssignments()) {
269+
// caseMessages's behavior has changed in 24.2, and hence it doesn't let Optional Action work.
270+
// Changing the below condition for now. Was: (theCaseMessages || !hasAssignments())
271+
if (!hasAssignments()) {
270272
// Temp fix for 8.7 change: confirmationNote no longer coming through in caseMessages$.
271273
// So, if we get here and caseMessages$ is empty, use default value in DX API response
272274
setCaseMessages(theCaseMessages || localizedVal('Thank you! The next step in this case has been routed appropriately.', localeCategory));

packages/react-sdk-components/src/components/infra/NavBar/NavBar.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,4 +165,5 @@
165165

166166
.scrollable {
167167
overflow-y: scroll !important;
168+
min-height: 200px !important;
168169
}

packages/react-sdk-components/src/components/template/SimpleTable/SimpleTableManual/SimpleTableManual.tsx

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,16 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
258258
function generateRowsData() {
259259
// if referenceList is empty and dataPageName property value exists then make a datapage fetch call and get the list of data.
260260
if (!referenceList.length && dataPageName) {
261-
getDataPage(dataPageName, parameters, context).then(listData => {
262-
const data = formatRowsData(listData);
263-
myRows = data;
264-
setRowData(data);
265-
});
261+
getDataPage(dataPageName, parameters, context)
262+
.then(listData => {
263+
const data = formatRowsData(listData);
264+
myRows = data;
265+
setRowData(data);
266+
})
267+
.catch(e => {
268+
// eslint-disable-next-line no-console
269+
console.log(e);
270+
});
266271
} else {
267272
// The referenceList prop has the JSON data for each row to be displayed
268273
// in the table. So, iterate over referenceList to create the dataRows that

packages/react-sdk-components/tests/e2e/Digv2/FormFields/Attachment.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ test.describe('E2E test', () => {
106106
/** Testing error case by uploading empty file */
107107
await page.setInputFiles(`#AttachmentList`, [zeroBytesFile]);
108108
await expect(page.locator('div >> text="Error with one or more files"')).toBeVisible();
109-
await expect(page.locator(`div >> text="Empty file can't be uploaded."`)).toBeVisible();
109+
await expect(page.locator(`div >> text="Empty file can't be uploaded." >> nth=0`)).toBeVisible();
110110

111111
const errorFile = await page.locator('div[class="psdk-utility-card"]:has-text("Unable to upload file")');
112112
await errorFile.locator('button[aria-label="Delete Attachment"]').click();

packages/react-sdk-components/tests/e2e/Digv2/FormFields/Email.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ test.describe('E2E test', () => {
4444
/** Required tests */
4545
const requiredEmail = page.locator('input[data-test-id="96fa7548c363cdd5adb29c2c2749e436"]');
4646
requiredEmail.fill('[email protected]');
47+
requiredEmail.blur();
4748
await expect(page.locator('p.Mui-error.Mui-required')).toBeHidden();
4849

4950
/** Checking 'field label', 'placeholder', and 'helper text' */

0 commit comments

Comments
 (0)