Skip to content

Commit dcb3705

Browse files
committed
PR comments addressed
1 parent a20cd37 commit dcb3705

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

packages/react-sdk-components/src/samples/Embedded/MainScreen/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { makeStyles } from '@mui/styles';
55
import StoreContext from '../../../bridge/Context/StoreContext';
66
import createPConnectComponent from '../../../bridge/react_pconnect';
77

8-
import sdkConfigData from '../../../../../../sdk-config.json';
98
import ShoppingOptionCard from '../ShoppingOptionCard';
109
import ResolutionScreen from '../ResolutionScreen';
1110
import { shoppingOptions } from '../utils';
@@ -165,7 +164,7 @@ export default function MainScreen(props) {
165164
if (!mashupCaseType) {
166165
const caseTypes = PCore.getEnvironmentInfo()?.environmentInfoObject?.pyCaseTypeList;
167166
if (caseTypes && caseTypes.length > 0) {
168-
mashupCaseType = sdkConfigData.authConfig.mashupCaseType;
167+
mashupCaseType = mashupCaseType = caseTypes[0].pyWorkTypeImplementationClassName;
169168
}
170169
}
171170
let selectedPhoneGUID = '';

packages/react-sdk-components/src/theme.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type { Theme } from '@mui/material/styles';
44

55
import sdkConfig from '../../../sdk-config.json';
66

7-
87
/**
98
* Since makeStyles is now exported from @mui/styles package which does not know about Theme in the core package.
109
* you need to augment the DefaultTheme (empty object) in @mui/styles with Theme from the core.

sdk-config.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"comment_sdk_config": "This is the configuration file for the React SDK Components",
33
"sdk_optional_configs_doc_comment": "See the document(link below) for more details on all the available config settings",
44
"sdk_optional_configs_doc": "https://docs.pega.com/bundle/constellation-sdk/page/constellation-sdks/sdks/configuring-sdk-config-json.html",
5-
"theme": "dark",
5+
"theme": "light",
66
"authConfig": {
77
"authService": "pega",
88

@@ -14,8 +14,7 @@
1414
"mashupPassword": "",
1515

1616
"portalClientId_comment": "Client ID from the OAuth 2.0 Client Registration record used for portal use case",
17-
"portalClientId": "25795373220702300272",
18-
"mashupCaseType": "DIXL-MediaCo-Work-PurchasePhone"
17+
"portalClientId": "25795373220702300272"
1918
},
2019

2120
"serverConfig": {
@@ -32,7 +31,7 @@
3231
"appPortal": "",
3332

3433
"appMashupCaseType_comment": "If specified, uses this case type for mashup. Otherwise, uses the first case type found for the app",
35-
"appMashupCaseType": "",
34+
"appMashupCaseType": "DIXL-MediaCo-Work-PurchasePhone",
3635

3736
"excludePortals_comment": "Array of specific portals to avoid attempting to load with SDK",
3837
"excludePortals": ["pxExpress", "Developer", "pxPredictionStudio", "pxAdminStudio", "pyCaseWorker", "pyCaseManager7"]

tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"allowJs": true, // must be false for @pega/pcore-pconnect-typedefs
1616
"noImplicitAny": false,
1717
"allowSyntheticDefaultImports": true,
18-
"resolveJsonModule": true,
1918
// End of copied from SDK-R
2019

2120
// Need to add this to remove errors of .js files trying to compile to the same path

0 commit comments

Comments
 (0)