Making translations actually work

[Miniontoby]

Hi,

I had been working on making the translations actually be usable for pterodactyl lately, but since this is a fork that is more active, I was thinking that it might be more useful here.

I would be glad to take this task on me, if wanted.

Kind regards,
Miniontoby

Update:
It seems like the feature/filament branch includes the new panel.
I guess this is going to be the new frontend, so I guess I will have to make that translatable instead

Update:
Current patch file can be found at https://github.com/pelican-dev/panel/pull/140.diff

[Boy132]

Correct. feature/filament is the development branch for the new backend ui made with filament.
The frontend ui will be converted eventually too.
Localization is planned.

[Miniontoby]

I am already working on making the new filament page translatable, now.

I might even make a PR when I am done...

[Poseidon281]

There is a crowdin page. So if you have source files that need to be translated they can be added to the crowdin page for translation

[Miniontoby]

Yeah, I saw the crowdin page, also joined it now.

But would it be fine if I just commit my code and then it gets uploaded using the crowdin cli?

I got English and Dutch at the same time for the feature/filament branch.

Translated the Dashboard and most of the other pages/resources also.

Also included changes to the default ptero frontend and backend, but focussed mostly on the new filament views.

Also, most of the already existing keys are not used in the panel itself, so most of them are not useful to translate...

[Poseidon281]

Yeah, I saw the crowdin page, also joined it now.

But would it be fine if I just commit my code and then it gets uploaded using the crowdin cli?

I got English and Dutch at the same time for the feature/filament branch.

Translated the Dashboard and most of the other pages/resources also.

Also included changes to the default ptero frontend and backend, but focussed mostly on the new filament views.

Also, most of the already existing keys are not used in the panel itself, so most of them are not useful to translate...

What have you translated right now/created a translate for? Just so i dont do the work double. Maybe create a draft PR just so people can see your progress and to avoid double work

[Poseidon281]

Yes just your work until now make a PR and I can help with making the translation file to. I can finish making it. Have a bit of spare time.

[Miniontoby]

Oke, deleted the patch file since I made #140

[Miniontoby]

@Poseidon281

Yes just your work until now make a PR and I can help with making the translation file to. I can finish making it. Have a bit of spare time.

I also have enough spare time, tho. And I like to be part of this as a developer.
But yeah, we could of course do this together... Possibly the best to make like a todo board so we can decide who does what, then.
You could join my github team, since you are Dutch, so if you would like to and then we can do a collab PR, for last bits and pieces?

[Poseidon281]

I can create a TODO board as a Trello and for now i can join your Github Team.

[Miniontoby]

Yeah, trello could also, but why not just use Github, since it already has it in there

[Miniontoby]

Oke, deleted the patch file since I made #140

New patch is https://github.com/pelican-dev/panel/pull/140.diff

[lancepioch]

Thanks, we need to revisit translations from the ground up!