ImageLayer API change between 2.x & 3.7

[JRobinsonEnvitia]

Hi,

I'm upgrading our product to the latest OSGEarth release. I've noticed that the constructors for ImageLayer have been removed and replaced by a static create() function. What's the intended way to construct an ImageLayer object and attach a tilesource now?

For reference my previous code looked like this :

layerBinding.imageLayer = new osgEarth::ImageLayer(ilOptions, layerBinding.tileSource);
Where layerBinding.tileSource is an overridden TileSource object that implements the overridden methods required to load my custom data into an osg::Image object. And ilOptions is a osgEarth::ImageLayer::Options object.

I see how setting the options directly on the layer should work, but not how to connect a tilesource.

Any help is much appreciated, as I couldn't find anything about this in the upgrade notes, and trying different layer subtypes doesn't seem to provide the behaviour I want.

Thanks

[JRobinsonEnvitia]

I've looked at creating my own texture layer that overrides ImageLayer as per the osgearth_map example but this isn't a great solution due to our codebase relying heavily on the previous implementation.

[gwaldron]

The concept of the TileSource is long deprecated, though you can use them using the backwards compatibility types TileSourceImageLayer and TileSourceElevationLayer. These are both in the osgEarth::Contrib namespace.

[JRobinsonEnvitia]

Thank you for the quick response. I've taken a look at this layer and noted that the constructor API is still different to the older versions of ImageLayers that accepted tile sources. Is there any documentation or examples for this layer? I was unable to find any in the current repo.

Am I along the right lines in thinking that I need to convert my overridden osgEarth::contrib::tileSource class into a driver and attach that to the layer somehow?

[gwaldron]

Sorry, no docs. It only remains in the SDK for legacy support.

If you want to submit a PR to add a setTileSource() function, we'll merge it.

[JRobinsonEnvitia]

No problem. I've managed to get our application working using a subclassed TileSourceImageLayer that provides the constructor I need. At some point I'll look at refactoring this as you suggest and raise as a PR. But for now at least it's working. Thanks for your help!