Cast to real responses in test network utils, download, and auth

Author: notatallshaw

tests/unit/test_network_auth.py

@@ -5,7 +5,7 @@
 import subprocess
 import sys
 from collections.abc import Iterable
-from typing import Any
+from typing import TYPE_CHECKING, Any, cast
 
 import pytest
 
@@ -14,6 +14,11 @@
 
 from tests.lib.requests_mocks import MockConnection, MockRequest, MockResponse
 
+if TYPE_CHECKING:
+    from requests.models import Response
+else:
+    from pip._vendor.requests.models import Response
+
 
 @pytest.fixture(autouse=True)
 def reset_keyring() -> Iterable[None]:
@@ -320,7 +325,7 @@ def _send(sent_req: MockRequest, **kwargs: Any) -> MockResponse:
     resp.status_code = 401
     resp.connection = connection
 
-    auth.handle_401(resp)
+    auth.handle_401(cast("Response", resp))
 
     if expect_save:
         assert keyring.saved_passwords == [("example.com", creds[0], creds[1])]
@@ -536,7 +541,7 @@ def _send(sent_req: MockRequest, **kwargs: Any) -> MockResponse:
     resp.status_code = 401
     resp.connection = connection
 
-    auth.handle_401(resp)
+    auth.handle_401(cast("Response", resp))
 
     if expect_save:
         assert keyring.saved_passwords == [("example.com", creds[0], creds[1])]

tests/unit/test_network_download.py

@@ -3,6 +3,7 @@
 import logging
 import sys
 from pathlib import Path
+from typing import TYPE_CHECKING, cast
 from unittest.mock import MagicMock, call, patch
 
 import pytest
@@ -21,6 +22,11 @@
 
 from tests.lib.requests_mocks import MockResponse
 
+if TYPE_CHECKING:
+    from requests.models import Response
+else:
+    from pip._vendor.requests.models import Response
+
 
 @pytest.mark.parametrize(
     "url, headers, from_cache, range_start, expected",
@@ -91,9 +97,9 @@ def test_log_download(
     if from_cache:
         resp.from_cache = from_cache
     link = Link(url)
-    total_length = _get_http_response_size(resp)
+    total_length = _get_http_response_size(cast("Response", resp))
     _log_download(
-        resp,
+        cast("Response", resp),
         link,
         progress_bar="on",
         total_length=total_length,

tests/unit/test_network_utils.py

@@ -1,10 +1,17 @@
+from typing import TYPE_CHECKING, cast
+
 import pytest
 
 from pip._internal.exceptions import NetworkConnectionError
 from pip._internal.network.utils import raise_for_status
 
 from tests.lib.requests_mocks import MockResponse
 
+if TYPE_CHECKING:
+    from requests.models import Response
+else:
+    from pip._vendor.requests.models import Response
+
 
 @pytest.mark.parametrize(
     "status_code, error_type",
@@ -20,7 +27,7 @@ def test_raise_for_status_raises_exception(status_code: int, error_type: str) ->
     resp.url = "http://www.example.com/whatever.tgz"
     resp.reason = "Network Error"
     with pytest.raises(NetworkConnectionError) as excinfo:
-        raise_for_status(resp)
+        raise_for_status(cast("Response", resp))
     assert str(excinfo.value) == (
         f"{status_code} {error_type}: Network Error for url:"
         " http://www.example.com/whatever.tgz"
@@ -33,4 +40,4 @@ def test_raise_for_status_does_not_raises_exception() -> None:
     resp.status_code = 201
     resp.url = "http://www.example.com/whatever.tgz"
     resp.reason = "No error"
-    raise_for_status(resp)
+    raise_for_status(cast("Response", resp))