Move all vendored libraries with stubs into TYPE_CHECKING block

Author: notatallshaw

pyproject.toml

@@ -91,7 +91,7 @@ docs = [
   "sphinx-issues"
 ]
 
-# Libraries that are not required for pip to run, 
+# Libraries that are not required for pip to run,
 # but are used in some optional features.
 all-optional = ["keyring"]
 

src/pip/_internal/commands/install.py

@@ -7,9 +7,9 @@
 import shutil
 import site
 from optparse import SUPPRESS_HELP, Values
+from typing import TYPE_CHECKING
 
 from pip._vendor.packaging.utils import canonicalize_name
-from pip._vendor.requests.exceptions import InvalidProxyURL
 from pip._vendor.rich import print_json
 
 # Eagerly import self_outdated_check to avoid crashes. Otherwise,
@@ -60,6 +60,12 @@
 )
 from pip._internal.wheel_builder import build, should_build_for_install_command
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from requests.exceptions import InvalidProxyURL
+else:
+    from pip._vendor.requests.exceptions import InvalidProxyURL
+
 logger = getLogger(__name__)
 
 

src/pip/_internal/exceptions.py

@@ -27,7 +27,8 @@
 if TYPE_CHECKING:
     from hashlib import _Hash
 
-    from pip._vendor.requests.models import Request, Response
+    # Vendored libraries with type stubs
+    from requests.models import Request, Response
 
     from pip._internal.metadata import BaseDistribution
     from pip._internal.network.download import _FileDownload

src/pip/_internal/index/collector.py

@@ -18,15 +18,12 @@
 from html.parser import HTMLParser
 from optparse import Values
 from typing import (
+    TYPE_CHECKING,
     Callable,
     NamedTuple,
     Protocol,
 )
 
-from pip._vendor import requests
-from pip._vendor.requests import Response
-from pip._vendor.requests.exceptions import RetryError, SSLError
-
 from pip._internal.exceptions import NetworkConnectionError
 from pip._internal.models.link import Link
 from pip._internal.models.search_scope import SearchScope
@@ -38,6 +35,15 @@
 
 from .sources import CandidatesFromPage, LinkSource, build_source
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    import requests
+    from requests import Response
+    from requests.exceptions import RetryError, SSLError
+else:
+    from pip._vendor import requests
+    from pip._vendor.requests.exceptions import RetryError, SSLError
+
 logger = logging.getLogger(__name__)
 
 ResponseHeaders = MutableMapping[str, str]

src/pip/_internal/locations/__init__.py

@@ -6,7 +6,7 @@
 import pathlib
 import sys
 import sysconfig
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 from pip._internal.models.scheme import SCHEME_KEYS, Scheme
 from pip._internal.utils.compat import WINDOWS
@@ -131,8 +131,13 @@ def _looks_like_red_hat_scheme() -> bool:
     (fortunately?) done quite unconditionally, so we create a default command
     object without any configuration to detect this.
     """
-    from distutils.command.install import install
-    from distutils.dist import Distribution
+    if TYPE_CHECKING:
+        # Vendored libraries with type stubs
+        from setuptools._distutils.command.install import install
+        from setuptools._distutils.dist import Distribution
+    else:
+        from distutils.command.install import install
+        from distutils.dist import Distribution
 
     cmd: Any = install(Distribution())
     cmd.finalize_options()

src/pip/_internal/locations/_distutils.py

@@ -19,17 +19,28 @@
 import logging
 import os
 import sys
-from distutils.cmd import Command as DistutilsCommand
 from distutils.command.install import SCHEME_KEYS
-from distutils.command.install import install as distutils_install_command
-from distutils.sysconfig import get_python_lib
+from typing import TYPE_CHECKING
 
 from pip._internal.models.scheme import Scheme
 from pip._internal.utils.compat import WINDOWS
 from pip._internal.utils.virtualenv import running_under_virtualenv
 
 from .base import get_major_minor_version
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from setuptools._distutils.cmd import Command as DistutilsCommand
+    from setuptools._distutils.command.install import (
+        install as distutils_install_command,
+    )
+    from setuptools._distutils.dist import Distribution  # noqa: F401
+    from setuptools._distutils.sysconfig import get_python_lib
+else:
+    from distutils.command.install import install as distutils_install_command
+    from distutils.sysconfig import get_python_lib
+
+
 logger = logging.getLogger(__name__)
 
 
@@ -46,7 +57,8 @@ def distutils_scheme(
     """
     Return a distutils install scheme
     """
-    from distutils.dist import Distribution
+    if not TYPE_CHECKING:
+        from distutils.dist import Distribution
 
     dist_args: dict[str, str | list[str]] = {"name": dist_name}
     if isolated:

src/pip/_internal/network/auth.py

@@ -17,11 +17,7 @@
 from functools import cache
 from os.path import commonprefix
 from pathlib import Path
-from typing import Any, NamedTuple
-
-from pip._vendor.requests.auth import AuthBase, HTTPBasicAuth
-from pip._vendor.requests.models import Request, Response
-from pip._vendor.requests.utils import get_netrc_auth
+from typing import TYPE_CHECKING, Any, NamedTuple
 
 from pip._internal.utils.logging import getLogger
 from pip._internal.utils.misc import (
@@ -33,6 +29,16 @@
 )
 from pip._internal.vcs.versioncontrol import AuthInfo
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from requests.auth import AuthBase, HTTPBasicAuth
+    from requests.models import Request, Response
+    from requests.utils import get_netrc_auth
+else:
+    from pip._vendor.requests.auth import AuthBase, HTTPBasicAuth
+    from pip._vendor.requests.utils import get_netrc_auth
+
+
 logger = getLogger(__name__)
 
 KEYRING_DISABLED = False

src/pip/_internal/network/cache.py

@@ -7,15 +7,18 @@
 from collections.abc import Generator
 from contextlib import contextmanager
 from datetime import datetime
-from typing import Any, BinaryIO, Callable
+from typing import TYPE_CHECKING, Any, BinaryIO, Callable
 
 from pip._vendor.cachecontrol.cache import SeparateBodyBaseCache
 from pip._vendor.cachecontrol.caches import SeparateBodyFileCache
-from pip._vendor.requests.models import Response
 
 from pip._internal.utils.filesystem import adjacent_tmp_file, replace
 from pip._internal.utils.misc import ensure_dir
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from requests.models import Response
+
 
 def is_from_cache(response: Response) -> bool:
     return getattr(response, "from_cache", False)

src/pip/_internal/network/download.py

@@ -9,13 +9,7 @@
 from collections.abc import Iterable, Mapping
 from dataclasses import dataclass
 from http import HTTPStatus
-from typing import BinaryIO
-
-from pip._vendor.requests import PreparedRequest
-from pip._vendor.requests.models import Response
-from pip._vendor.urllib3 import HTTPResponse as URLlib3Response
-from pip._vendor.urllib3._collections import HTTPHeaderDict
-from pip._vendor.urllib3.exceptions import ReadTimeoutError
+from typing import TYPE_CHECKING, BinaryIO
 
 from pip._internal.cli.progress_bars import BarType, get_download_progress_renderer
 from pip._internal.exceptions import IncompleteDownloadError, NetworkConnectionError
@@ -26,6 +20,19 @@
 from pip._internal.network.utils import HEADERS, raise_for_status, response_chunks
 from pip._internal.utils.misc import format_size, redact_auth_from_url, splitext
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from requests import PreparedRequest
+    from requests.models import Response
+    from urllib3 import HTTPResponse as URLlib3Response
+    from urllib3._collections import HTTPHeaderDict
+    from urllib3.exceptions import ReadTimeoutError
+else:
+    from pip._vendor.requests import PreparedRequest
+    from pip._vendor.urllib3 import HTTPResponse as URLlib3Response
+    from pip._vendor.urllib3._collections import HTTPHeaderDict
+    from pip._vendor.urllib3.exceptions import ReadTimeoutError
+
 logger = logging.getLogger(__name__)
 
 

src/pip/_internal/network/lazy_wheel.py

@@ -8,16 +8,21 @@
 from collections.abc import Generator
 from contextlib import contextmanager
 from tempfile import NamedTemporaryFile
-from typing import Any
+from typing import TYPE_CHECKING, Any
 from zipfile import BadZipFile, ZipFile
 
 from pip._vendor.packaging.utils import canonicalize_name
-from pip._vendor.requests.models import CONTENT_CHUNK_SIZE, Response
 
 from pip._internal.metadata import BaseDistribution, MemoryWheel, get_wheel_distribution
 from pip._internal.network.session import PipSession
 from pip._internal.network.utils import HEADERS, raise_for_status, response_chunks
 
+if TYPE_CHECKING:
+    # Vendored libraries with type stubs
+    from requests.models import CONTENT_CHUNK_SIZE, Response
+else:
+    from pip._vendor.requests.models import CONTENT_CHUNK_SIZE
+
 
 class HTTPRangeRequestUnsupported(Exception):
     pass