prevent unnecessary error throwing in stringifyRule

megboehlert · megboehlert · commit 10662a5752f4 · 2025-04-24T11:08:30.000-04:00
diff --git a/.changeset/pink-queens-shave.md b/.changeset/pink-queens-shave.md
@@ -0,0 +1,5 @@
+---
+"rrweb-snapshot": patch
+---
+
+Prevent unnecessary error throwing in stringifyRule that was nullifying csstext of style elements when serializing nodes
diff --git a/packages/rrweb-snapshot/src/utils.ts b/packages/rrweb-snapshot/src/utils.ts
@@ -170,7 +170,7 @@ export function stringifyRule(rule: CSSRule, sheetHref: string | null): string {
     } catch (error) {
       importStringified = rule.cssText;
     }
-    if (rule.styleSheet.href) {
+    if (rule?.styleSheet?.href) {
       // url()s within the imported stylesheet are relative to _that_ sheet's href
       return absolutifyURLs(importStringified, rule.styleSheet.href);
     }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"rrweb-snapshot": patch
 +---
++
 +Prevent unnecessary error throwing in stringifyRule that was nullifying csstext of style elements when serializing nodes
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ export function stringifyRule(rule: CSSRule, sheetHref: string \| null): string {`
`170`	`170`	`} catch (error) {`
`171`	`171`	`importStringified = rule.cssText;`
`172`	`172`	`}`
`173`		`- if (rule.styleSheet.href) {`
	`173`	`+ if (rule?.styleSheet?.href) {`
`174`	`174`	`// url()s within the imported stylesheet are relative to _that_ sheet's href`
`175`	`175`	`return absolutifyURLs(importStringified, rule.styleSheet.href);`
`176`	`176`	`}`