Skip to content

Commit fa43312

Browse files
authored
Merge pull request #58 from pendo-io/jc-pendo-move-nodeIds-calc-outside-for-loop
fix: move nodeIds calculation outside for loop
2 parents 2bd0f40 + b9cb956 commit fa43312

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/rrweb/src/replay/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1742,9 +1742,10 @@ export class Replayer {
17421742
);
17431743
break;
17441744
}
1745+
1746+
const ids = nodeIdsToBeAdded(resolveTrees);
17451747
for (const tree of resolveTrees) {
17461748
const parent = mirror.getNode(tree.value.parentId);
1747-
const ids = nodeIdsToBeAdded(resolveTrees);
17481749
if (!parent && !ids.has(tree.value.parentId)) {
17491750
this.debug(
17501751
'Drop resolve tree since there is no parent for the root node.',

0 commit comments

Comments
 (0)