fixup: Unconditionally run filter() during resampling

Author: msarehn

src/sampling.rs

@@ -101,32 +101,23 @@ impl<F> Sampler<F> {
                 .collect::<Vec<_>>();
             let transform = |zk| state.cov_transform() * zk;
 
-            match constraints {
+            let ok_constraints = |yk: &DVector<f64>| match constraints {
                 Some(constraints) => {
-                    let ok_constraints = |yk: &DVector<f64>| {
-                        let point = to_point(&yk, state.mean(), state.sigma());
-                        constraints.meets_constraints(&point)
-                    };
-
-                    if parallel_update {
-                        z.into_par_iter()
-                            .map(transform)
-                            .filter(ok_constraints)
-                            .collect()
-                    } else {
-                        z.into_iter()
-                            .map(transform)
-                            .filter(ok_constraints)
-                            .collect()
-                    }
-                }
-                None => {
-                    if parallel_update {
-                        z.into_par_iter().map(transform).collect()
-                    } else {
-                        z.into_iter().map(transform).collect()
-                    }
+                    constraints.meets_constraints(&to_point(&yk, state.mean(), state.sigma()))
                 }
+                None => true,
+            };
+
+            if parallel_update {
+                z.into_par_iter()
+                    .map(transform)
+                    .filter(ok_constraints)
+                    .collect()
+            } else {
+                z.into_iter()
+                    .map(transform)
+                    .filter(ok_constraints)
+                    .collect()
             }
         };