Fixed configuration loss bug

Author: penguin86

…danieleverducci/ojo/CamerasSettings.java …ava/it/danieleverducci/ojo/Settings.javaapp/src/main/java/it/danieleverducci/ojo/CamerasSettings.java renamed to app/src/main/java/it/danieleverducci/ojo/Settings.java app/src/main/java/it/danieleverducci/ojo/CamerasSettings.java renamed to app/src/main/java/it/danieleverducci/ojo/Settings.java

@@ -19,20 +19,21 @@
 /**
  * Manages the settings persistence
  */
-public class CamerasSettings implements Serializable {
+public class Settings implements Serializable {
+    private static final long serialVersionUID = 1081285022445419696L;
     private static final String FILENAME = "settings.bin";
     private static final String TAG = "Settings";
 
     private volatile String settingsFilePath;
     private List<Camera> cameras = new ArrayList<>();
 
-    public static CamerasSettings fromDisk(Context context) {
+    public static Settings fromDisk(Context context) {
         String filePath = context.getFilesDir() + File.separator + FILENAME;
-        CamerasSettings s = new CamerasSettings();
+        Settings s = new Settings();
         try {
             FileInputStream fin = new FileInputStream(filePath);
             ObjectInputStream ois = new ObjectInputStream(fin);
-            s = (CamerasSettings) ois.readObject();
+            s = (Settings) ois.readObject();
         } catch (FileNotFoundException e) {
             Log.d(TAG, "No saved settings found, will create a new one");
         } catch (IOException e) {

app/src/main/java/it/danieleverducci/ojo/entities/Camera.java

@@ -3,6 +3,7 @@
 import java.io.Serializable;
 
 public class Camera implements Serializable {
+    private static final long serialVersionUID = -3837361587400158910L;
     private String name;
     private String rtspUrl;
 

app/src/main/java/it/danieleverducci/ojo/ui/SettingsFragment.java

@@ -1,7 +1,5 @@
 package it.danieleverducci.ojo.ui;
 
-import android.app.AlertDialog;
-import android.app.Dialog;
 import android.graphics.Color;
 import android.os.Bundle;
 
@@ -21,7 +19,7 @@
 import java.util.List;
 
 import it.danieleverducci.ojo.R;
-import it.danieleverducci.ojo.CamerasSettings;
+import it.danieleverducci.ojo.Settings;
 import it.danieleverducci.ojo.SharedPreferencesManager;
 import it.danieleverducci.ojo.databinding.FragmentSettingsItemListBinding;
 import it.danieleverducci.ojo.entities.Camera;
@@ -34,7 +32,7 @@
 public class SettingsFragment extends Fragment {
 
     private FragmentSettingsItemListBinding binding;
-    private CamerasSettings camerasSettings;
+    private Settings settings;
 
     @Override
     public View onCreateView(LayoutInflater inflater, ViewGroup container,
@@ -79,8 +77,8 @@ public void onResume() {
         super.onResume();
 
         // Load cameras
-        camerasSettings = CamerasSettings.fromDisk(getContext());
-        List<Camera> cams = camerasSettings.getCameras();
+        settings = Settings.fromDisk(getContext());
+        List<Camera> cams = settings.getCameras();
 
         // Set the adapter
         RecyclerView recyclerView = binding.list;
@@ -109,7 +107,7 @@ public void onPause() {
 
         // Save cameras
         List<Camera> cams = ((SettingsRecyclerViewAdapter)binding.list.getAdapter()).getItems();
-        this.camerasSettings.setCameras(cams);
-        this.camerasSettings.save();
+        this.settings.setCameras(cams);
+        this.settings.save();
     }
 }

app/src/main/java/it/danieleverducci/ojo/ui/StreamUrlFragment.java

@@ -13,23 +13,23 @@
 import com.google.android.material.snackbar.Snackbar;
 
 import it.danieleverducci.ojo.R;
-import it.danieleverducci.ojo.CamerasSettings;
+import it.danieleverducci.ojo.Settings;
 import it.danieleverducci.ojo.databinding.FragmentAddStreamBinding;
 import it.danieleverducci.ojo.entities.Camera;
 
 public class StreamUrlFragment extends Fragment {
     public static final String ARG_CAMERA = "arg_camera";
 
     private FragmentAddStreamBinding binding;
-    private CamerasSettings camerasSettings;
+    private Settings settings;
     private Integer selectedCamera = null;
 
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
         // Load existing settings (if any)
-        camerasSettings = CamerasSettings.fromDisk(getContext());
+        settings = Settings.fromDisk(getContext());
     }
 
     @Override
@@ -45,7 +45,7 @@ public View onCreateView(
         if (args != null && args.containsKey(ARG_CAMERA)) {
             this.selectedCamera = args.getInt(ARG_CAMERA);
 
-            Camera c = camerasSettings.getCameras().get(this.selectedCamera);
+            Camera c = settings.getCameras().get(this.selectedCamera);
             binding.streamName.setText(c.getName());
             binding.streamName.setHint(getContext().getString(R.string.stream_list_default_camera_name).replace("{camNo}", (this.selectedCamera+1)+""));
             binding.streamUrl.setText(c.getRtspUrl());
@@ -74,16 +74,16 @@ public void onClick(View view) {
 
                 if (StreamUrlFragment.this.selectedCamera != null) {
                     // Update camera
-                    Camera c = camerasSettings.getCameras().get(StreamUrlFragment.this.selectedCamera);
+                    Camera c = settings.getCameras().get(StreamUrlFragment.this.selectedCamera);
                     c.setName(name);
                     c.setRtspUrl(url);
                 } else {
                     // Add stream to list
-                    camerasSettings.addCamera(new Camera(name, url));
+                    settings.addCamera(new Camera(name, url));
                 }
 
                 // Save
-                if (!camerasSettings.save()) {
+                if (!settings.save()) {
                     Snackbar.make(view, R.string.add_stream_error_saving, Snackbar.LENGTH_LONG).show();
                     return;
                 }

app/src/main/java/it/danieleverducci/ojo/ui/SurveillanceFragment.java

@@ -28,7 +28,7 @@
 import java.util.List;
 
 import it.danieleverducci.ojo.R;
-import it.danieleverducci.ojo.CamerasSettings;
+import it.danieleverducci.ojo.Settings;
 import it.danieleverducci.ojo.databinding.FragmentSurveillanceBinding;
 import it.danieleverducci.ojo.entities.Camera;
 import it.danieleverducci.ojo.utils.DpiUtils;
@@ -137,7 +137,7 @@ public void onPause() {
 
 
     private void addAllCameras() {
-        CamerasSettings settings = CamerasSettings.fromDisk(getContext());
+        Settings settings = Settings.fromDisk(getContext());
         List<Camera> cc = settings.getCameras();
 
         int elemsPerSide = calcGridSideElements(cc.size());