Skip to content

Commit 9724f59

Browse files
Expand and reorder export data
1 parent dbd2547 commit 9724f59

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed

app/tests.py

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -408,9 +408,15 @@ def test_export_requests_content(self):
408408

409409
self.assertEqual(len(rows[0]), 25)
410410
self.assertEqual(rows[0][0], 'Event ID')
411-
self.assertEqual(len(rows), 2)
411+
self.assertEqual(len(rows), 3)
412412

413-
event_row = rows[1]
413+
# Only submitted events should be included (not saved ones)
414+
event_names = [row[1] for row in rows[1:]]
415+
self.assertIn('Test Event 2', event_names) # sort in descending order of created_at
416+
self.assertIn('Test Event 1', event_names)
417+
self.assertNotIn('Test Event 3', event_names)
418+
419+
event_row = rows[2] # grab row for test event 1
414420
self.assertEqual(event_row[1], 'Test Event 1')
415421
self.assertEqual(event_row[4], 'Houston Hall')
416422
self.assertEqual(event_row[5], str(self.requester_profile))
@@ -425,22 +431,3 @@ def test_export_requests_content(self):
425431
self.assertEqual(float(event_row[22]), 0.00)
426432
self.assertEqual(float(event_row[23]), 175.00)
427433
self.assertIn(str(self.funder.profile), event_row[24])
428-
429-
def test_export_requests_date_filter(self):
430-
old_date = datetime.datetime.now() - datetime.timedelta(days=731)
431-
Event.objects.create(
432-
name="Old Test Event", date="2020-01-01", time="12:30:00", location="Old Location",
433-
requester=self.requester_profile, contact_name="Old Contact", contact_email="old@upenn.edu",
434-
contact_phone="111-222-3333", anticipated_attendance=50, advisor_email="oldadvisor@upenn.edu",
435-
advisor_phone="444-555-6666", organizations="Old Organization", funding_already_received=25.00,
436-
status="B", created_at=old_date, updated_at=old_date
437-
)
438-
439-
self.client.login(username='admin', password='adminpassword')
440-
resp = self.client.get('/export-requests/')
441-
rows = list(csv.reader(resp.content.decode('utf-8').strip().split('\n')))
442-
443-
self.assertEqual(len(rows), 2)
444-
event_names = [row[1] for row in rows[1:]]
445-
self.assertIn('Test Event 1', event_names)
446-
self.assertNotIn('Old Test Event', event_names)

app/views.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,12 +483,11 @@ def export_requests(request):
483483
"""
484484
Export funding requests submitted in the last 2 years to a CSV file.
485485
"""
486-
# Query the last two years of submitted funding requests
487-
cutoff_date = datetime.datetime.now() - datetime.timedelta(days=730)
488486
qs = (
489-
Event.objects.filter(created_at__gte=cutoff_date, status="B")
487+
Event.objects.filter(~Q(status="S"))
490488
.select_related("requester", "requester__user")
491489
.prefetch_related("applied_funders", "item_set", "item_set__grant_set")
490+
.order_by("-created_at")
492491
)
493492

494493
output = io.StringIO()

0 commit comments

Comments
 (0)