Skip to content

fix unknowns displayed in transaction history and approval dialogue  #2604

@TalDerei

Description

@TalDerei

PositionOpen plans, eg. in the history tab on the portfolio page, still display as unknowns, even though we already know what the LpNFTs are at that point. They display correctly once the TxP and TxV are generated after expanding the history entry.

This is also still an issue for prax, where we're still seeing unknown asset metadata (for LpNFTs) in the approval dialog when providing liquidity?

One idea that's been floated by @cronokirby is a more holistic approach where the plan rendering should take the full context of the plan into account, for instance avoiding rendering LP NFTs that are the result of actions the plan itself performs. Position manipulation actions, in particular, shouldn’t render the spends or outputs for positions that are created or modified by the plan—they're implicit in the action.

orthogonal to #1394

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementpraxrefactorImproving existing system with new designuiRelated to user interface or ux design

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions