-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Since this is a hybrid project - both JS and Python - the Python side is left without any supervision when it comes to the code style.
There are already styling inconsistencies creeping into the code, like
./algo-core/onboarding.py:17:1: E302 expected 2 blank lines, found 1
./algo-core/onboarding.py:17:83: E231 missing whitespace after ','
./algo-core/onboarding.py:17:110: E202 whitespace before ')'
./algo-core/ortools_solver.py:646:21: E131 continuation line unaligned for hanging indent
./algo-core/scheduler_utils.py:45:121: E501 line too long (140 > 120 characters)
./algo-core/scheduler_utils.py:49:1: E302 expected 2 blank lines, found 1
./algo-core/scheduler_utils.py:55:1: E302 expected 2 blank lines, found 1
./algo-core/scheduler_utils.py:157:33: W292 no newline at end of file
I'd suggest running the black formatter as Alida used to do, by adding a developer dependency
poetry add --dev black
and formatting (from within the environment)
black --line-length 120 .
Or, even better, maybe it's possible to add
black --line-length 120 --check .
as part of the npm run lint so that it's checked automatically?
P.S. The black formatter is fully compatible with our internal Python CI pipeline.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels