Mark pipeline as failed when a failed job is found (#190)

Author: pepakriz

README.md

@@ -102,7 +102,7 @@ GITLAB_AUTH_TOKEN="<token>" yarn run start
 | `HTTP_SERVER_ENABLE`           | `false`              | It'll enable experimental API and dashboard support        |
 | `HTTP_SERVER_PORT`             | `4000`               | It'll use different http server port                       |
 | `WEB_HOOK_TOKEN`               | ``                   | It'll enable experimental web hook support                 |
-| `PERMISSION_VALIDATION`        | `false`              | It'll enable experimental permission validation            |
+| `ENABLE_PERMISSION_VALIDATION` | `false`              | It'll enable experimental permission validation            |
 
 ## Development
 

server/src/MergeRequestAcceptor.ts

@@ -20,7 +20,7 @@ import { JobStatus } from './generated/graphqlgen';
 
 export enum AcceptMergeRequestResultKind {
 	SuccessfullyMerged,
-	ClosedMergeRequest,
+	NotOpenMergeRequest,
 	ReassignedMergeRequest,
 	CanNotBeMerged,
 	HasConflict,
@@ -47,8 +47,8 @@ interface SuccessResponse extends Response {
 	mergeRequestInfo: MergeRequestInfo;
 }
 
-interface ClosedMergeRequestResponse extends Response {
-	kind: AcceptMergeRequestResultKind.ClosedMergeRequest;
+interface NotOpenMergeRequestResponse extends Response {
+	kind: AcceptMergeRequestResultKind.NotOpenMergeRequest;
 	mergeRequestInfo: MergeRequestInfo;
 }
 
@@ -129,7 +129,7 @@ interface PipelineInProgressResponse extends Response {
 
 export type AcceptMergeRequestResult =
 	| SuccessResponse
-	| ClosedMergeRequestResponse
+	| NotOpenMergeRequestResponse
 	| ReassignedMergeRequestResponse
 	| CanNotBeMergedResponse
 	| HasConflictResponse
@@ -143,7 +143,7 @@ export type AcceptMergeRequestResult =
 
 export type MergeMergeRequestResult =
 	| SuccessResponse
-	| ClosedMergeRequestResponse
+	| NotOpenMergeRequestResponse
 	| ReassignedMergeRequestResponse
 	| CanNotBeMergedResponse
 	| HasConflictResponse
@@ -233,18 +233,14 @@ export const acceptMergeRequest = async (
 		};
 	}
 
-	if (mergeRequestInfo.state === MergeState.Closed) {
+	if (mergeRequestInfo.state !== MergeState.Opened) {
 		return {
-			kind: AcceptMergeRequestResultKind.ClosedMergeRequest,
+			kind: AcceptMergeRequestResultKind.NotOpenMergeRequest,
 			mergeRequestInfo,
 			user,
 		};
 	}
 
-	if (mergeRequestInfo.state !== MergeState.Opened) {
-		throw new Error(`Unexpected MR status: ${mergeRequestInfo.state}`);
-	}
-
 	if (mergeRequestInfo.detailed_merge_status === DetailedMergeStatus.DiscussionsNotResolved) {
 		return {
 			kind: AcceptMergeRequestResultKind.UnresolvedDiscussion,
@@ -449,7 +445,7 @@ export const runAcceptingMergeRequest = async (
 	);
 	if (
 		mergeResponse.kind === AcceptMergeRequestResultKind.SuccessfullyMerged ||
-		mergeResponse.kind === AcceptMergeRequestResultKind.ClosedMergeRequest ||
+		mergeResponse.kind === AcceptMergeRequestResultKind.NotOpenMergeRequest ||
 		mergeResponse.kind === AcceptMergeRequestResultKind.Unauthorized ||
 		mergeResponse.kind === AcceptMergeRequestResultKind.WorkInProgress ||
 		mergeResponse.kind === AcceptMergeRequestResultKind.UnresolvedDiscussion ||
@@ -520,6 +516,19 @@ export const runAcceptingMergeRequest = async (
 			await gitlabApi.getPipelineJobs(mergeRequestInfo.project_id, currentPipeline.id),
 		);
 
+		// Mark pipeline as failed when a failed job is found
+		const failedJob = jobs.find(
+			(job) => !job.allow_failure && job.status === PipelineJobStatus.Failed,
+		);
+		if (failedJob !== undefined) {
+			return {
+				kind: AcceptMergeRequestResultKind.FailedPipeline,
+				mergeRequestInfo,
+				user,
+				pipeline: currentPipeline,
+			};
+		}
+
 		const manualJobsToRun = jobs.filter(
 			(job) => PipelineJobStatus.Manual === job.status && !job.allow_failure,
 		);

server/src/MergeRequestReceiver.ts

@@ -80,7 +80,16 @@ export const prepareMergeRequestForMerge = async (
 	}
 
 	if (mergeRequest.state === MergeState.Merged) {
-		await assignToAuthorAndResetLabels(gitlabApi, mergeRequest, user);
+		await setBotLabels(gitlabApi, mergeRequest, []);
+		return;
+	}
+
+	if (mergeRequest.state !== MergeState.Opened) {
+		await Promise.all([
+			assignToAuthorAndResetLabels(gitlabApi, mergeRequest, user),
+			setBotLabels(gitlabApi, mergeRequest, []),
+		]);
+
 		return;
 	}
 

server/src/MergeRequestResultResolver.ts

@@ -61,8 +61,8 @@ export const resolveMergeRequestResult = async (
 		return;
 	}
 
-	if (result.kind === AcceptMergeRequestResultKind.ClosedMergeRequest) {
-		console.log(`[MR][${mergeRequestInfo.iid}] Merge request is closed, ending`);
+	if (result.kind === AcceptMergeRequestResultKind.NotOpenMergeRequest) {
+		console.log(`[MR][${mergeRequestInfo.iid}] Merge request is not open, ending`);
 
 		await Promise.all([
 			tryCancelPipeline(gitlabApi, mergeRequestInfo, user),