Skip to content

Commit 9330c35

Browse files
authored
merge_error can be set when MR is mergeable (#31)
1 parent c3032da commit 9330c35

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/MergeRequestAcceptor.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,7 @@ export const acceptMergeRequest = async (gitlabApi: GitlabApi, mergeRequest: Mer
135135
continue;
136136
}
137137

138-
if (
139-
mergeRequestInfo.merge_status !== MergeStatus.CanBeMerged
140-
|| mergeRequestInfo.merge_error !== null
141-
|| mergeRequestInfo.work_in_progress
142-
) {
138+
if (mergeRequestInfo.work_in_progress) {
143139
return {
144140
kind: AcceptMergeRequestResultKind.CanNotBeMerged,
145141
mergeRequestInfo,
@@ -159,6 +155,14 @@ export const acceptMergeRequest = async (gitlabApi: GitlabApi, mergeRequest: Mer
159155
continue;
160156
}
161157

158+
if (mergeRequestInfo.merge_status !== MergeStatus.CanBeMerged) {
159+
return {
160+
kind: AcceptMergeRequestResultKind.CanNotBeMerged,
161+
mergeRequestInfo,
162+
user,
163+
};
164+
}
165+
162166
if (containsLabel(mergeRequestInfo.labels, BotLabels.Rebasing)) {
163167
await gitlabApi.updateMergeRequest(mergeRequest.project_id, mergeRequest.iid, {
164168
labels: [...filterBotLabels(mergeRequestInfo.labels)].join(','),

0 commit comments

Comments
 (0)