Skip to content

Commit c4f354d

Browse files
authored
Try to fix conflict after rebase (#87)
1 parent b7d6526 commit c4f354d

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

server/src/MergeRequestAcceptor.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,6 @@ const containsAssignedUser = (mergeRequest: MergeRequest, user: User) => {
183183
const userIds = mergeRequest.assignees.map((assignee) => assignee.id);
184184
return userIds.includes(user.id);
185185
};
186-
const defaultPipelineValidationRetries = 5;
187-
const defaultRebasingRetries = 1;
188186

189187
export const filterBotLabels = (labels: string[]): string[] => {
190188
const values = Object.values(BotLabels) as string[];
@@ -398,9 +396,6 @@ export const runAcceptingMergeRequest = async (
398396
): Promise<AcceptMergeRequestResult | void> => {
399397
console.log(`[MR][${mergeRequestIid}] Checking...`);
400398

401-
let numberOfPipelineValidationRetries = defaultPipelineValidationRetries;
402-
let numberOfRebasingRetries = defaultRebasingRetries;
403-
404399
const mergeResponse = await acceptMergeRequest(
405400
gitlabApi,
406401
projectId,
@@ -440,7 +435,7 @@ export const runAcceptingMergeRequest = async (
440435
}
441436

442437
if (mergeRequestInfo.diverged_commits_count > 0) {
443-
if (numberOfRebasingRetries <= 0 && mergeRequestInfo.merge_error !== null) {
438+
if (!mergeRequestInfo.rebase_in_progress && mergeRequestInfo.merge_error !== null) {
444439
console.log(`[MR][${mergeRequestInfo.iid}] Merge error after rebase`);
445440
return {
446441
kind: AcceptMergeRequestResultKind.CanNotBeMerged,
@@ -452,7 +447,6 @@ export const runAcceptingMergeRequest = async (
452447
console.log(`[MR][${mergeRequestInfo.iid}] source branch is not up to date, rebasing`);
453448
await tryCancelPipeline(gitlabApi, mergeRequestInfo, user);
454449
await gitlabApi.rebaseMergeRequest(mergeRequestInfo.project_id, mergeRequestInfo.iid);
455-
numberOfRebasingRetries--;
456450
job.updateStatus(JobStatus.REBASING);
457451
return;
458452
}
@@ -514,11 +508,6 @@ export const runAcceptingMergeRequest = async (
514508
: `[MR][${mergeRequestInfo.iid}] Merge request can't be merged. The latest pipeline is not executed on the latest commit`;
515509
console.log(message);
516510

517-
if (numberOfPipelineValidationRetries > 0) {
518-
numberOfPipelineValidationRetries--;
519-
return;
520-
}
521-
522511
return {
523512
kind: AcceptMergeRequestResultKind.InvalidPipeline,
524513
mergeRequestInfo,

0 commit comments

Comments
 (0)