Fixed PipelineStatus.Created handling (#64)

pepakriz · web-flow · commit e930a921dd51 · 2020-04-02T16:28:21.000+02:00
diff --git a/src/MergeRequestAcceptor.ts b/src/MergeRequestAcceptor.ts
@@ -118,7 +118,6 @@ export enum BotLabels {
 const startingOrInProgressPipelineStatuses = [
 	PipelineStatus.Running,
 	PipelineStatus.Pending,
-	PipelineStatus.Created,
 	PipelineStatus.WaitingForResource,
 	PipelineStatus.Preparing,
 ];
@@ -328,7 +327,11 @@ export const acceptMergeRequest = async (gitlabApi: GitlabApi, mergeRequest: Mer
 				};
 			}
 
-			if (currentPipeline.status !== PipelineStatus.Success && currentPipeline.status !== PipelineStatus.Skipped) {
+			if (
+				currentPipeline.status !== PipelineStatus.Success
+				&& currentPipeline.status !== PipelineStatus.Skipped
+				&& currentPipeline.status !== PipelineStatus.Created
+			) {
 				throw new Error(`Unexpected pipeline status: ${currentPipeline.status}`);
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ export enum BotLabels {`
`118`	`118`	`const startingOrInProgressPipelineStatuses = [`
`119`	`119`	`PipelineStatus.Running,`
`120`	`120`	`PipelineStatus.Pending,`
`121`		`- PipelineStatus.Created,`
`122`	`121`	`PipelineStatus.WaitingForResource,`
`123`	`122`	`PipelineStatus.Preparing,`
`124`	`123`	`];`
`@@ -328,7 +327,11 @@ export const acceptMergeRequest = async (gitlabApi: GitlabApi, mergeRequest: Mer`
`328`	`327`	`};`
`329`	`328`	`}`
`330`	`329`
`331`		`- if (currentPipeline.status !== PipelineStatus.Success && currentPipeline.status !== PipelineStatus.Skipped) {`
	`330`	`+ if (`
	`331`	`+ currentPipeline.status !== PipelineStatus.Success`
	`332`	`+ && currentPipeline.status !== PipelineStatus.Skipped`
	`333`	`+ && currentPipeline.status !== PipelineStatus.Created`
	`334`	`+ ) {`
`332`	`335`	throw new Error(`Unexpected pipeline status: ${currentPipeline.status}`);
`333`	`336`	`}`
`334`	`337`	`}`