Merge pull request #24 from pepijn-devries/work-in-progress

Fix for #23

Author: pepijn-devries

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: ggsankeyfier
 Type: Package
 Title: Create Sankey and Alluvial Diagrams Using 'ggplot2'
-Version: 0.1.8.0006
+Version: 0.1.8.0007
 Authors@R: c(person("Pepijn", "de Vries", role = c("aut", "cre", "dtc"),
     email = "pepijn.devries@outlook.com",
     comment = c(ORCID = "0000-0002-7961-6646")),
@@ -46,7 +46,7 @@ Suggests:
 License: GPL (>= 3)
 Encoding: UTF-8
 LazyData: true
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.2
 Roxygen: list(markdown = TRUE)
 Collate: 
     'draw_edges.r'

NEWS.md

@@ -1,9 +1,10 @@
-ggsankeyfier v0.1.8.0006
+ggsankeyfier v0.1.8.0007
 -------------
 
  * Added check workflow
  * Added code coverage workflow and badge
  * Improved test coverage
+ * Fix for [issue #23](https://github.com/pepijn-devries/ggsankeyfier/issues/23)
 
 ggsankeyfier v0.1.8
 -------------

R/position_helpers.r

@@ -6,8 +6,10 @@
       tidyr::pivot_longer(dplyr::any_of(c("node_id", "node_id_end")),
                           names_to = "which", values_to = "node_id") |>
       dplyr::mutate(x_fix = ifelse(.data$which == "node_id", .data[["x"]], .data[["xend"]])) |>
-      .group_across("PANEL", "x_fix", "node_id", "which") |>
+      .group_across("PANEL", "connector", "x_fix", "node_id", "which") |>
       dplyr::summarise(node_size = sum(.data[["y"]])) |>
+      .group_across("PANEL", "x_fix", "node_id", "which") |>
+      dplyr::summarise(node_size = max(.data$node_size)) |>
       .group_across("PANEL", "node_id") |>
       dplyr::mutate(is_max = max(.data[["node_size"]]) == .data[["node_size"]]) |>
       dplyr::select(-"which") |>
@@ -244,7 +246,6 @@
 
     data |>
       dplyr::rename_with(~gsub("_to$", "_end", .), dplyr::ends_with("_to")) |>
-      # dplyr::rename(group_end = "group_to") |>
       dplyr::mutate(connector_end = "to") |>
       dplyr::left_join(nodes, by = c("PANEL", "connector", "edge_id")) |>
       dplyr::left_join(