now error raising are coherent with paper

Author: peppedilillo

grb-trigger-algorithms/algorithms/pfocus.py

@@ -74,14 +74,14 @@ def __call__(
         self.global_max = 0.0
         self.time_offset = 0
         for t, (x_t, b_t) in enumerate(zip(xs, bs)):
+            if b_t <= 0:
+                raise ValueError("background rate must be greater than zero.")
             self.update(x_t, b_t)
             if self.global_max > self.threshold_llr:
                 return sqrt(2 * self.global_max), -self.time_offset + t + 1, t
         return 0.0, len(xs) + 1, len(xs)
 
     def update(self, x, b):
-        if b <= 0:
-            raise ValueError("Background rate must be greater than zero.")
         p = self.curve_list.pop(-1)
         acc = Curve(p.x + x, p.b + b, p.t + 1, p.m)
         while dominate(p, self.curve_list[-1], acc) <= 0:

grb-trigger-algorithms/algorithms/pfocus_des.py

@@ -116,6 +116,8 @@ def step(self, x):
         x_t_m = self.buffer.popleft()
         self.des_update(x_t_m)
         self.lambda_t = self.s_t + self.m * self.b_t
+        if self.lambda_t <= 0:
+            raise ValueError("background rate must be greater than zero.")
         self.focus.update(x, self.lambda_t)
         if self.focus.global_max:
             significance, offset = self.qc()
@@ -127,7 +129,6 @@ def init(**kwargs):
     """
     For compatibility with exhaustive and conventional algorithms.
     """
-
     def run(xs):
         """
         Args:

grb-trigger-algorithms/algorithms/pfocus_minimal.py

@@ -22,8 +22,6 @@ def focus_maximize(cs):
 
 
 def focus_update(cs, x, b, c):
-    if b <= 0:
-        raise ValueError("Background rate must be greater than zero.")
     if cs and dominates(k := curve_update(cs[0], x, b), c):
         return [k] + focus_update(cs[1:], x, b, k)
     return [(0, 0.0, 0)]
@@ -52,6 +50,8 @@ def focus(xs: list[int], bs: list[float], threshold: float):
     cs = [(0, 0.0, 0)]
 
     for t, (x_t, b_t) in enumerate(zip(xs, bs)):
+        if b_t <= 0:
+            raise ValueError("background rate must be greater than zero.")
         cs = focus_update(cs, x_t, b_t, (1, 1.0, 0))
         global_max, time_offset = focus_maximize(cs)
         if global_max > threshold:

grb-trigger-algorithms/algorithms/pfocus_true.py

@@ -41,6 +41,8 @@ def run(xs: list[int]):
                 return sqrt(2 * focus.global_max), t - focus.time_offset + 1, t
         return 0, t + 1, t
 
+    if b <= 0:
+        raise ValueError("background rate must be greater than zero.")
     if mu_min < 1:
         raise ValueError("mumin must be greater or equal 1.0")
     if threshold <= 0: