mocking level of unit tests increased

Author: peppierre

.gitignore

@@ -2,6 +2,7 @@
 node_modules
 lib
 coverage
+tmp
 *.log
 .idea
 *.ipr

.istanbul.yml

@@ -2,7 +2,7 @@ instrumentation:
   root: src
   include-all-sources: true
   default-excludes: true
-  excludes: ['**/*.spec.js', '**/*.spec.def.js', 'index.js']
+  excludes: ['**/*.spec.js', '**/*.spec-def.js', '**/index.js']
   es-modules: true
 extensions:
     - .js

docs/interface/api-adapter/README.md

@@ -6,13 +6,15 @@ API Adapter interface is a common way to make API plugginable to applications. W
 
 ### Criteria against
 
-1. Adapter must have `pluginCall` and `request` methods implemented.
+1. Adapter must have `pluginCall`, `unplugCall` and `request` methods implemented.
 
 **Example**
 
     class MyApiAdapter {
         pluginCall() {}
         
+        unplugCall() {}
+        
         request(data) {
             return JSON.stringify(data);
         }

docs/objects/application/README.md

@@ -6,10 +6,12 @@ Application object provides ability work with features of application. This incl
 
 [getFeature()](get-feature/README.md)
 
-[getFeatures()](get-features/README.md)
+[getFeatureNames()](get-feature-names/README.md)
 
 [extendWithFeature()](extend-with-feature/README.md)
 
+[shrinkWithFeature()](shrink-with-feature/README.md)
+
 [executeFeature()](execute-feature/README.md)
 
 [apiAdapter](api-adapter/README.md)

…jects/application/get-features/README.md …/application/get-feature-names/README.mddocs/objects/application/get-features/README.md renamed to docs/objects/application/get-feature-names/README.md docs/objects/application/get-features/README.md renamed to docs/objects/application/get-feature-names/README.md

@@ -1,20 +1,20 @@
-### getFeatures()
+### getFeatureNames()
 
-[Index](/docs/README.md) | [Objects in Globular](/docs/objects/README.md) | [Application](/docs/objects/application/README.md) | getFeatures()
+[Index](/docs/README.md) | [Objects in Globular](/docs/objects/README.md) | [Application](/docs/objects/application/README.md) | getFeatureNames()
 
 Returns IDs of application's available features.
 
 **Signature**
 
-    myApp.getFeatures()
+    myApp.getFeatureNames()
 
 **Return value**
 
 Array containing string IDs of features.
 
 **Example**
 
-    const featureList = myApp.getFeatures();
+    const featureList = myApp.getFeatureNames();
     if (featureList.indexOf('check-wind-condictions') < 0) {
         throw new Error('Missing feature: Check Wind Conditions');
     }

docs/objects/application/shrink-with-feature/README.md

@@ -0,0 +1,26 @@
+### shrinkWithFeature()
+
+[Index](/docs/README.md) | [Objects in Globular](/docs/objects/README.md) | [Application](/docs/objects/application/README.md) | shrinkWithFeature()
+
+Removes a feature from application's functionality.
+
+**Signature**
+
+    myApplication.WithFeature(featureName)
+    
+**Parameters**
+
+`featureName`
+
+*(mandatory)* String identifier to uniquely identify feature.
+
+**Example**
+
+    class ReserveRoom {
+        execute() {
+            // to some stuffs
+        }
+    }
+    
+    myApplication.extendWithFeature('reserve-room', ReserveRoom);
+    myApplication.shrinkWithFeature('reserve-room');

package.json

@@ -42,7 +42,7 @@
     "babel-core": "6.18.0",
     "babel-eslint": "7.1.1",
     "babel-loader": "6.2.7",
-    "babel-plugin-add-module-exports": "^0.2.1",
+    "babel-plugin-add-module-exports": "0.2.1",
     "babel-plugin-transform-runtime": "6.15.0",
     "babel-preset-es2015": "6.18.0",
     "babel-preset-es2015-loose": "7.0.0",
@@ -59,12 +59,12 @@
     "isparta": "4.0.0",
     "istanbul": "0.4.5",
     "mocha": "3.0.2",
-    "node-localstorage": "^1.3.0",
+    "node-localstorage": "1.3.0",
     "phantomjs": "1.9.20",
     "phantomjs-prebuilt": "2.1.13",
     "rimraf": "2.5.4",
     "sinon": "3.2.1",
-    "sinon-chai": "2.8.0",
+    "sinon-chai": "2.14.0",
     "webpack": "2.4.0"
   },
   "devEngines": {

src/Globular.js

@@ -1,4 +1,4 @@
-import ApiAdapter from './modules/api/ApiAdapter';
+import { ApiAdapter } from './modules/api/ApiAdapter';
 import ApplicationFactory from './modules/application';
 
 const applications = new Map();

src/Globular.spec.js

@@ -1,62 +1,53 @@
-import { expect } from 'chai';
 import sinon from 'sinon';
-import { LocalStorage } from 'node-localstorage';
+import { expect } from 'chai';
 
-import globular from './Globular';
-import ApplicationFactory from './modules/application';
-import isInterfaceImplemented from './util/isInterfaceImplemented';
-import isMethod from './util/isMethod';
+import Globular from './Globular';
 
-describe('globular Framework', () => {
-    context('when no custom plugins defined', () => {
-        it('should create a new application', () => {
-            expect(isInterfaceImplemented(globular.initializeApp('sample-app'), ['getFeatures', 'getFeature', 'extendWithFeature', 'executeFeature'])).to.be.equal(true);
-        });
-        it('should return application immediately when initialized', () => {
-            const initializedApp = globular.initializeApp('sample-app');
-            const application = globular.app('sample-app');
-            expect(application).to.equal(initializedApp);
-        });
-    });
-    context('when custom plugins defined', () => {
-        let FactoryStub;
+import ApplicationFactory from './modules/application/ApplicationFactory';
 
+describe('Globular Framework', () => {
+    context('when no API nor persitency passed', () => {
         beforeEach(() => {
-            FactoryStub = sinon.stub(ApplicationFactory, 'produce');
+            sinon.stub(ApplicationFactory, 'produce').returns({ });
         });
+
         afterEach(() => {
-            FactoryStub.restore();
-        });
-        it('should pass Persistency Adapter to newly created application', () => {
-            const localStorageToInject = new LocalStorage('./tmp/localStorage');
-            globular.initializeApp('sample-app', { persistency: localStorageToInject });
-            expect(FactoryStub.calledOnce).to.be.equal(true);
-            expect(FactoryStub.lastCall.args[0].persistency).to.be.equal(localStorageToInject);
+            ApplicationFactory.produce.restore();
         });
-        it('should pass API Adapter to newly created application', () => {
-            const apiAdapterToInject = { pluginCall() {}, request() {} };
-            globular.initializeApp('sample-app', { api: apiAdapterToInject });
-            expect(FactoryStub.calledOnce).to.be.equal(true);
-            expect(FactoryStub.lastCall.args[0].api).to.be.equal(apiAdapterToInject);
+
+        it('should indicate application factory to produce an app with API but with no persitency', () => {
+            Globular.initializeApp('sampleApp');
+
+            const callArgs = ApplicationFactory.produce.firstCall.args;
+            expect(ApplicationFactory.produce.calledOnce).to.be.equal(true);
+            expect(callArgs[0].api).to.not.be.equal(undefined);
+            expect(callArgs[0].persistency).to.be.equal(undefined);
         });
-        it('should pass default API Adapter instance to application when no Adapter defined', () => {
-            globular.initializeApp('sample-app1');
-            expect(FactoryStub.lastCall.args[0].api).not.to.be.equal(undefined);
 
-            globular.initializeApp('sample-app2', {});
-            expect(FactoryStub.lastCall.args[0].api).not.to.be.equal(undefined);
+        it('should indicate application factory to produce an with persitency passed to', () => {
+            const persistency = { };
+            Globular.initializeApp('sampleApp', { persistency });
 
-            globular.initializeApp('sample-app3', { persistency: new LocalStorage('./tmp/localStorage') });
-            expect(FactoryStub.lastCall.args[0].api).not.to.be.equal(undefined);
+            const callArgs = ApplicationFactory.produce.firstCall.args;
+            expect(ApplicationFactory.produce.calledOnce).to.be.equal(true);
+            expect(callArgs[0].api).to.not.be.equal(undefined);
+            expect(callArgs[0].persistency).to.be.equal(persistency);
         });
-    });
 
-    context('when examining interface', () => {
-        it('should have expected overall interface', () => {
-            expect(isInterfaceImplemented(globular, ['initializeApp', 'app'])).to.be.equal(true);
+        it('should indicate application factory to produce an with API passed to', () => {
+            const api = { };
+            Globular.initializeApp('sampleApp', { api });
+
+            const callArgs = ApplicationFactory.produce.firstCall.args;
+            expect(ApplicationFactory.produce.calledOnce).to.be.equal(true);
+            expect(callArgs[0].api).to.be.equal(api);
+            expect(callArgs[0].persistency).to.be.equal(undefined);
         });
-        it('should have expected API Adapter interface', () => {
-            expect(isMethod(globular.Api)).to.be.equal(true);
+
+        it('should make newly created app to be available', () => {
+            const app = Globular.initializeApp('sampleApp');
+
+            expect(Globular.app('sampleApp')).to.be.equal(app);
         });
     });
 });

src/modules/api/ApiAdapter.js

@@ -1,6 +1,4 @@
-import isMethod from '../../util/isMethod';
-
-export default function ApiAdapter() {
+export function ApiAdapter() {
     const calls = new Map();
 
     function isAlreadyPluggedIn(id) {
@@ -32,7 +30,7 @@ export default function ApiAdapter() {
     /* eslint-disable class-methods-use-this */
     return new class {
         pluginCall(id, call) {
-            if (!isMethod(call)) {
+            if (typeof call !== 'function') {
                 throw new TypeError('Invalid API call');
             }
             if (isAlreadyPluggedIn(id)) {
@@ -43,6 +41,14 @@ export default function ApiAdapter() {
             /* eslint-enable no-eval */
         }
 
+        unplugCall(id) {
+            calls.delete(id);
+        }
+
+        getAvailableCalls() {
+            return Array.from(calls.keys());
+        }
+
         request(id, data) {
             return new Promise((resolve, reject) => {
                 if (!isAlreadyPluggedIn(id)) {