Fix incorrect shortcut path when comparing ranked to non-ranked scores

peppy · peppy · commit 3cd10a832868 · 2026-03-03T02:10:11.000+09:00
diff --git a/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Maintenance/MarkNonPreservedScoresCommand.cs b/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Maintenance/MarkNonPreservedScoresCommand.cs
@@ -207,7 +207,7 @@ private static bool checkIsUserHigh(IEnumerable<SoloScore> userScores, SoloScore
             Debug.Assert(scores.Any());
 
             // shortcut for case of single score match
-            if (scores.Length == 1)
+            if (scores.Length == 1 && scores.Single().id == candidate.id)
             {
                 preservedAlternatives = new HashSet<SoloScore> { candidate };
                 return true;

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ private static bool checkIsUserHigh(IEnumerable<SoloScore> userScores, SoloScore`
`207`	`207`	`Debug.Assert(scores.Any());`
`208`	`208`
`209`	`209`	`// shortcut for case of single score match`
`210`		`- if (scores.Length == 1)`
	`210`	`+ if (scores.Length == 1 && scores.Single().id == candidate.id)`
`211`	`211`	`{`
`212`	`212`	`preservedAlternatives = new HashSet<SoloScore> { candidate };`
`213`	`213`	`return true;`