Add support for deleting legacy replays and scores

Author: peppy

osu.Server.Queues.ScoreStatisticsProcessor/Commands/Maintenance/DeleteNonPreservedScoresCommand.cs

@@ -142,9 +142,13 @@ private async Task processPartitionAsync(MySqlConnection db, Amazon.S3.IAmazonS3
 
                 if (score.is_legacy_score)
                 {
-                    // TODO: we likely do want logic here to handle the cleanup of replays.
-                    // for now, make sure we don't attempt to clean up stable scores with replays here.
-                    throw new InvalidOperationException($"Legacy score id:{score.id} legacy_id:{score.legacy_score_id} has replay flag set");
+                    DogStatsd.Increment("legacy_scores_deleted");
+                    var rulesetSpecifics = LegacyDatabaseHelper.GetRulesetSpecifics(score.ruleset_id);
+
+                    await s3.DeleteObjectAsync(rulesetSpecifics.ReplayBucket, score.legacy_score_id.ToString(), cancellationToken);
+
+                    await db.ExecuteAsync($"DELETE FROM {rulesetSpecifics.ReplayTable} WHERE score_id = @scoreId", new { scoreId = score.legacy_score_id });
+                    await db.ExecuteAsync($"DELETE FROM {rulesetSpecifics.HighScoreTable} WHERE score_id = @scoreId", new { scoreId = score.legacy_score_id });
                 }
 
                 if (!DryRun)

osu.Server.Queues.ScoreStatisticsProcessor/Helpers/LegacyDatabaseHelper.cs

@@ -40,6 +40,7 @@ public class RulesetDatabaseInfo
             public readonly string LeadersTable;
             public readonly string UserStatsTable;
             public readonly string ReplayTable;
+            public readonly string ReplayBucket;
             public readonly string LastProcessedPpUserCount;
             public readonly string LastProcessedPpScoreCount;
             public readonly string TodaysRankColumn;
@@ -60,6 +61,8 @@ public RulesetDatabaseInfo(int rulesetId, string rulesetIdentifier, bool legacyS
                 LeadersTable = $"`{dbName}`.`osu_leaders{tableSuffix}`";
                 UserStatsTable = $"`{dbName}`.`osu_user_stats{tableSuffix}`";
                 ReplayTable = $"`{dbName}`.`osu_replays{tableSuffix}`";
+                ReplayBucket = $"replay-{rulesetIdentifier}";
+
                 LastProcessedPpUserCount = $"pp_last_user_id{tableSuffix}";
                 LastProcessedPpScoreCount = $"pp_last_score_id{tableSuffix}";
                 TodaysRankColumn = $"pp_rank_column_{rulesetIdentifier}";