Skip to content

Commit 52184a4

Browse files
committed
Wrap signing certificate password in single quotes to prevent corruption
High quality passwords may contain characters with special treatment by the shell (e.g., $). The previous use of double quotes in the shell command for importing the macOS signing certificate to the runner's keychain resulted in the password being corrupted, and thus a spurious failure in this case: ``` security: SecKeychainItemImport: The user name or passphrase you entered is not correct. ```
1 parent 66c48c7 commit 52184a4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/publish-go-nightly-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ jobs:
140140
-f pkcs12 \
141141
-A \
142142
-T /usr/bin/codesign \
143-
-P "${{ secrets.INSTALLER_CERT_MAC_PASSWORD }}"
143+
-P '${{ secrets.INSTALLER_CERT_MAC_PASSWORD }}'
144144
145145
security set-key-partition-list \
146146
-S apple-tool:,apple: \

.github/workflows/release-go-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ jobs:
150150
-f pkcs12 \
151151
-A \
152152
-T "/usr/bin/codesign" \
153-
-P "${{ secrets.INSTALLER_CERT_MAC_PASSWORD }}"
153+
-P '${{ secrets.INSTALLER_CERT_MAC_PASSWORD }}'
154154
155155
security set-key-partition-list \
156156
-S apple-tool:,apple: \

0 commit comments

Comments
 (0)