Intel compiler workaround for transfer() in comm expand routines

Intel 2025 segfaults on allocatable assignment from transfer(). Use
section notation (array(:), array(:,:), array(:,:,:)) to prevent
reallocation on Intel compilers only.

Author: perazz

.claude/settings.local.json

@@ -10,7 +10,10 @@
       "Bash(git push:*)",
       "Bash(grep:*)",
       "Bash(fpm build:*)",
-      "Bash(git status:*)"
+      "Bash(git status:*)",
+      "Bash(git pull:*)",
+      "Bash(git stash:*)",
+      "Bash(git revert:*)"
     ],
     "deny": [],
     "ask": []

project/fitpack.cbp

@@ -97,7 +97,7 @@
 			<Option weight="0" />
 		</Unit>
 		<Unit filename="../src/fitpack_curves.f90">
-			<Option weight="1" />
+			<Option weight="0" />
 		</Unit>
 		<Unit filename="../src/fitpack_curves_c.f90">
 			<Option weight="0" />
@@ -136,16 +136,16 @@
 			<Option weight="0" />
 		</Unit>
 		<Unit filename="../test/fitpack_curve_tests.f90">
-			<Option weight="1" />
+			<Option weight="0" />
 		</Unit>
 		<Unit filename="../test/fitpack_test_data.f90">
 			<Option weight="0" />
 		</Unit>
 		<Unit filename="../test/fitpack_tests.f90">
-			<Option weight="1" />
+			<Option weight="0" />
 		</Unit>
 		<Unit filename="../test/test.f90">
-			<Option weight="2" />
+			<Option weight="0" />
 		</Unit>
 		<Unit filename="../test/test_curve.cpp" />
 		<Extensions />

project/fitpack.fdepend

@@ -0,0 +1,45 @@
+# fdepslib dependency file v1.1
+1771258224source:/Users/federico/code/fitpack/src/fitpack.f90
+
+1704620662source:/Users/federico/code/fitpack/src/fitpack_closed_c.f90
+
+1704623491source:/Users/federico/code/fitpack/src/fitpack_constrained_c.f90
+
+1771258028source:/Users/federico/code/fitpack/src/fitpack_core.f90
+
+1766849605source:/Users/federico/code/fitpack/src/fitpack_core_c.f90
+
+1771259882source:/Users/federico/code/fitpack/src/fitpack_curves.f90
+
+1764238257source:/Users/federico/code/fitpack/src/fitpack_curves_c.f90
+
+1771259888source:/Users/federico/code/fitpack/src/fitpack_grid_surfaces.f90
+
+1771259891source:/Users/federico/code/fitpack/src/fitpack_gridded_polar.f90
+
+1771259893source:/Users/federico/code/fitpack/src/fitpack_gridded_sphere.f90
+
+1771259882source:/Users/federico/code/fitpack/src/fitpack_parametric.f90
+
+1741628651source:/Users/federico/code/fitpack/src/fitpack_parametric_c.f90
+
+1771259895source:/Users/federico/code/fitpack/src/fitpack_parametric_surfaces.f90
+
+1703948614source:/Users/federico/code/fitpack/src/fitpack_periodic_curves_c.f90
+
+1771259887source:/Users/federico/code/fitpack/src/fitpack_polar.f90
+
+1771259889source:/Users/federico/code/fitpack/src/fitpack_spheres.f90
+
+1771259882source:/Users/federico/code/fitpack/src/fitpack_surfaces.f90
+
+1704617612source:/Users/federico/code/fitpack/test/fitpack_cpp_tests.f90
+
+1771258900source:/Users/federico/code/fitpack/test/fitpack_curve_tests.f90
+
+1740771300source:/Users/federico/code/fitpack/test/fitpack_test_data.f90
+
+1765036074source:/Users/federico/code/fitpack/test/fitpack_tests.f90
+
+1771258788source:/Users/federico/code/fitpack/test/test.f90
+

src/fitpack_core.F90

@@ -18461,7 +18461,13 @@ pure subroutine FP_REAL_COMM_EXPAND_1D(array, buffer)
         if (all(bnd /= FP_NOT_ALLOC)) then
             allocate(array(bnd(1):bnd(2)))
             n = FP_RCOMMS_PER_BITS(size(array, kind=FP_SIZE) * storage_size(array))
+#if defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)
+            ! Intel: avoid transfer() — temporary overflows the stack for large arrays.
+            ! FP_REAL == FP_COMM (both c_double), so direct assignment is valid.
+            array(:) = buffer(header+1:header+n)
+#else
             array = transfer(buffer(header+1:header+n), array)
+#endif
         end if
     end subroutine FP_REAL_COMM_EXPAND_1D
 
@@ -18478,7 +18484,13 @@ pure subroutine FP_REAL_COMM_EXPAND_2D(array, buffer)
         if (all(bnd /= FP_NOT_ALLOC)) then
             allocate(array(bnd(1,1):bnd(2,1), bnd(1,2):bnd(2,2)))
             n = FP_RCOMMS_PER_BITS(size(array, kind=FP_SIZE) * storage_size(array))
+#if defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)
+            ! Intel: avoid transfer() — temporary overflows the stack for large arrays.
+            ! FP_REAL == FP_COMM (both c_double), so reshape buffer directly.
+            array(:,:) = reshape(buffer(header+1:header+n), shape(array))
+#else
             array = reshape(transfer(buffer(header+1:header+n), array, size(array)), shape(array))
+#endif
         end if
     end subroutine FP_REAL_COMM_EXPAND_2D
 
@@ -18495,7 +18507,13 @@ pure subroutine FP_REAL_COMM_EXPAND_3D(array, buffer)
         if (all(bnd /= FP_NOT_ALLOC)) then
             allocate(array(bnd(1,1):bnd(2,1), bnd(1,2):bnd(2,2), bnd(1,3):bnd(2,3)))
             n = FP_RCOMMS_PER_BITS(size(array, kind=FP_SIZE) * storage_size(array))
+#if defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)
+            ! Intel: avoid transfer() — temporary overflows the stack for large arrays.
+            ! FP_REAL == FP_COMM (both c_double), so reshape buffer directly.
+            array(:,:,:) = reshape(buffer(header+1:header+n), shape(array))
+#else
             array = reshape(transfer(buffer(header+1:header+n), array, size(array)), shape(array))
+#endif
         end if
     end subroutine FP_REAL_COMM_EXPAND_3D
 
@@ -18512,7 +18530,11 @@ pure subroutine FP_SIZE_COMM_EXPAND_1D(array, buffer)
         if (all(bnd /= FP_NOT_ALLOC)) then
             allocate(array(bnd(1):bnd(2)))
             ndoubles = FP_RCOMMS_PER_BITS(size(array, kind=FP_SIZE) * storage_size(array))
+#if defined(__INTEL_COMPILER) || defined(__INTEL_LLVM_COMPILER)
+            array(:) = transfer(buffer(header+1:header+ndoubles), 0_FP_SIZE, size(array))
+#else
             array = transfer(buffer(header+1:header+ndoubles), array)
+#endif
         end if
     end subroutine FP_SIZE_COMM_EXPAND_1D