fix(delete user): add error message when a user tries to delete an admin (#145)

The role needs to be changed before deletion.

Author: perber

internal/core/auth/errors.go

@@ -6,4 +6,5 @@ var ErrUserNotFound = errors.New("user not found")
 var ErrUserAlreadyExists = errors.New("user already exists")
 var ErrUserInvalidCredentials = errors.New("invalid credentials")
 var ErrUserInvalidRole = errors.New("invalid role")
+var ErrUserAdminCannotBeDeleted = errors.New("admin user cannot be deleted; change role before deletion")
 var ErrInvalidToken = errors.New("invalid token")

internal/core/auth/user_service.go

@@ -181,7 +181,7 @@ func (s *UserService) DeleteUser(id string) error {
 	}
 	// Check if user is admin
 	if user.HasRole(RoleAdmin) {
-		return ErrUserInvalidRole
+		return ErrUserAdminCannotBeDeleted
 	}
 	// Delete user from store
 	err = s.store.DeleteUser(id)

internal/core/auth/user_service_test.go

@@ -92,8 +92,8 @@ func TestUserService_DeleteUser(t *testing.T) {
 	// admin should not be deletable
 	admin, _ := service.CreateUser("admin", "admin@example.com", "secret", "admin")
 	err := service.DeleteUser(admin.ID)
-	if err != ErrUserInvalidRole {
-		t.Errorf("Expected ErrUserInvalidRole when deleting admin, got: %v", err)
+	if err != ErrUserAdminCannotBeDeleted {
+		t.Errorf("Expected ErrUserAdminCannotBeDeleted when deleting admin, got: %v", err)
 	}
 
 	editor, _ := service.CreateUser("editor", "editor@example.com", "secret", "editor")

ui/leafwiki-ui/src/features/users/DeleteUserButton.tsx

@@ -13,6 +13,7 @@ import { useAuthStore } from '@/stores/auth'
 import { useUserStore } from '@/stores/users'
 import { AlertDialogDescription } from '@radix-ui/react-alert-dialog'
 import { useState } from 'react'
+import { toast } from 'sonner'
 
 type Props = {
   userId: string
@@ -33,9 +34,16 @@ export function DeleteUserButton({ userId, username }: Props) {
     try {
       await deleteUser(userId)
       setOpen(false)
-    } catch (err) {
-      console.error('Error deleting user:', err)
-      // Optionally show an error message to the user
+    } catch (err: { error?: string } | unknown) {
+      if (err && typeof err === 'object' && 'error' in err) {
+        // Handle specific error message if available
+        console.error('Error deleting user:', (err as { error: string }).error)
+        toast.error(err.error as string)
+      } else {
+        // Handle generic error
+        console.error('Error deleting user:', err)
+        toast.error('Failed to delete user. Please try again.')
+      }
     } finally {
       setLoading(false)
     }