Skip to content

Commit 0b97543

Browse files
committed
Add shard label in collstats metrics
1 parent deaf106 commit 0b97543

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

exporter/collstats_collector.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,10 @@ func (d *collstatsCollector) collect(ch chan<- prometheus.Metric) {
138138
labels["collection"] = collection
139139

140140
for _, metrics := range stats {
141+
if shard, ok := metrics["shard"].(string); ok {
142+
labels["shard"] = shard
143+
}
144+
141145
for _, metric := range makeMetrics(prefix, metrics, labels, d.compatibleMode) {
142146
ch <- metric
143147
}

exporter/collstats_collector_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@ func TestCollStatsCollector(t *testing.T) {
5959
expected := strings.NewReader(`
6060
# HELP mongodb_collstats_latencyStats_commands_latency collstats.latencyStats.commands.
6161
# TYPE mongodb_collstats_latencyStats_commands_latency untyped
62-
mongodb_collstats_latencyStats_commands_latency{collection="testcol_00",database="testdb"} 0
63-
mongodb_collstats_latencyStats_commands_latency{collection="testcol_01",database="testdb"} 0
64-
mongodb_collstats_latencyStats_commands_latency{collection="testcol_02",database="testdb"} 0
62+
mongodb_collstats_latencyStats_commands_latency{collection="testcol_00",database="testdb",shard="rs1"} 0
63+
mongodb_collstats_latencyStats_commands_latency{collection="testcol_01",database="testdb",shard="rs1"} 0
64+
mongodb_collstats_latencyStats_commands_latency{collection="testcol_02",database="testdb",shard="rs1"} 0
6565
# HELP mongodb_collstats_latencyStats_transactions_ops collstats.latencyStats.transactions.
6666
# TYPE mongodb_collstats_latencyStats_transactions_ops untyped
67-
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_00",database="testdb"} 0
68-
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_01",database="testdb"} 0
69-
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_02",database="testdb"} 0
67+
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_00",database="testdb",shard="rs1"} 0
68+
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_01",database="testdb",shard="rs1"} 0
69+
mongodb_collstats_latencyStats_transactions_ops{collection="testcol_02",database="testdb",shard="rs1"} 0
7070
# HELP mongodb_collstats_storageStats_capped collstats.storageStats.
7171
# TYPE mongodb_collstats_storageStats_capped untyped
72-
mongodb_collstats_storageStats_capped{collection="testcol_00",database="testdb"} 0
73-
mongodb_collstats_storageStats_capped{collection="testcol_01",database="testdb"} 0
74-
mongodb_collstats_storageStats_capped{collection="testcol_02",database="testdb"} 0` +
72+
mongodb_collstats_storageStats_capped{collection="testcol_00",database="testdb",shard="rs1"} 0
73+
mongodb_collstats_storageStats_capped{collection="testcol_01",database="testdb",shard="rs1"} 0
74+
mongodb_collstats_storageStats_capped{collection="testcol_02",database="testdb",shard="rs1"} 0` +
7575
"\n")
7676

7777
// Filter metrics for 2 reasons:

0 commit comments

Comments
 (0)