drop tests

Author: idoqo

exporter/pbm_collector_test.go

@@ -17,21 +17,14 @@ package exporter
 
 import (
 	"context"
-	"fmt"
 	"strings"
 	"testing"
 	"time"
 
-	pbmconnect "github.com/percona/percona-backup-mongodb/pbm/connect"
-	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/testutil"
 	"github.com/prometheus/common/promslog"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.mongodb.org/mongo-driver/bson"
-	"go.mongodb.org/mongo-driver/mongo"
-	"go.mongodb.org/mongo-driver/mongo/options"
-	"go.mongodb.org/mongo-driver/mongo/readpref"
 
 	"github.com/percona/mongodb_exporter/internal/tu"
 )
@@ -71,163 +64,3 @@ func TestPBMCollector(t *testing.T) {
 		assert.Equal(t, expectedLength, count, "PBM metrics are missing")
 	})
 }
-
-// TestPBMCollectorConnectionLeak verifies that the PBM collector does not leak
-// MongoDB connections across multiple scrape cycles.
-//
-//nolint:paralleltest
-func TestPBMCollectorConnectionLeak(t *testing.T) {
-	ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
-	defer cancel()
-
-	port, err := tu.PortForContainer("mongo-2-1")
-	require.NoError(t, err)
-
-	mongoURI := fmt.Sprintf(
-		"mongodb://admin:[email protected]:%s/?connectTimeoutMS=500&serverSelectionTimeoutMS=500",
-		port,
-	) //nolint:gosec
-
-	client, err := mongo.Connect(ctx, options.Client().ApplyURI(mongoURI))
-	require.NoError(t, err)
-	t.Cleanup(func() {
-		client.Disconnect(ctx) //nolint:errcheck
-	})
-	err = client.Ping(ctx, nil)
-	require.NoError(t, err)
-
-	// Allow connections to stabilize
-	time.Sleep(100 * time.Millisecond)
-
-	initialConns := getServerConnectionCount(ctx, t, client)
-	t.Logf("Initial connections: %d", initialConns)
-
-	c := newPbmCollector(ctx, client, mongoURI, promslog.New(&promslog.Config{}))
-
-	// Run multiple collection cycles
-	const scrapeCount = 10
-	for i := 0; i < scrapeCount; i++ {
-		ch := make(chan prometheus.Metric, 100)
-		c.Collect(ch)
-		close(ch)
-		for range ch {
-		}
-	}
-
-	// Allow time for cleanup
-	time.Sleep(1 * time.Second)
-
-	finalConns := getServerConnectionCount(ctx, t, client)
-	connGrowth := finalConns - initialConns
-
-	t.Logf("Final connections: %d (growth=%d over %d scrapes)", finalConns, connGrowth, scrapeCount)
-
-	// With a leak: expect ~3-4 connections per scrape (one per cluster member)
-	// Without leak: should be near zero growth
-	assert.Less(t, connGrowth, int64(scrapeCount),
-		"Connection leak detected: server connections grew by %d over %d scrapes", connGrowth, scrapeCount)
-}
-
-// TestPBMSDKConnectionLeakOnPingFailure tests the PBM SDK's connect.MongoConnect
-// for connection leaks when Ping fails after Connect succeeds.
-//
-// The bug in PBM SDK's connect.MongoConnectWithOpts():
-//   - mongo.Connect() succeeds (establishes connections)
-//   - Ping() fails (e.g., unreachable server, wrong replica set)
-//   - Connection is NOT disconnected -> connections leak
-//
-// This test uses an unsatisfiable ReadPreference to trigger Ping failure
-// after the driver has established connections.
-//
-//nolint:paralleltest
-func TestPBMSDKConnectionLeakOnPingFailure(t *testing.T) {
-	ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
-	defer cancel()
-
-	port, err := tu.PortForContainer("mongo-2-1")
-	require.NoError(t, err)
-
-	// Create a monitoring client to check server connection count
-	monitorURI := fmt.Sprintf("mongodb://admin:[email protected]:%s/", port) //nolint:gosec
-	monitorClient, err := mongo.Connect(ctx, options.Client().ApplyURI(monitorURI))
-	require.NoError(t, err)
-	t.Cleanup(func() {
-		monitorClient.Disconnect(ctx) //nolint:errcheck
-	})
-	err = monitorClient.Ping(ctx, nil)
-	require.NoError(t, err)
-
-	// Allow connections to stabilize
-	time.Sleep(100 * time.Millisecond)
-
-	initialConns := getServerConnectionCount(ctx, t, monitorClient)
-	t.Logf("Initial connections: %d", initialConns)
-
-	const iterations = 5
-
-	for i := 0; i < iterations; i++ {
-		// Use a ReadPreference that cannot be satisfied to trigger the leak:
-		// 1. mongo.Connect() succeeds and establishes connections
-		// 2. Ping() fails because no server matches the tag selector
-		// 3. Without proper cleanup, connections are leaked
-		_, err := pbmconnect.MongoConnect(ctx,
-			monitorURI,
-			pbmconnect.AppName("leak-test"),
-			func(opts *options.ClientOptions) error {
-				opts.SetReadPreference(readpref.Nearest(readpref.WithTags("dc", "nonexistent")))
-				opts.SetServerSelectionTimeout(300 * time.Millisecond)
-				return nil
-			},
-		)
-		require.Error(t, err, "MongoConnect should fail due to unsatisfiable ReadPreference")
-		t.Logf("Iteration %d: MongoConnect failed as expected", i)
-	}
-
-	// Allow time for any cleanup
-	time.Sleep(500 * time.Millisecond)
-
-	finalConns := getServerConnectionCount(ctx, t, monitorClient)
-	connGrowth := finalConns - initialConns
-
-	t.Logf("Final connections: %d (growth=%d over %d iterations)", finalConns, connGrowth, iterations)
-
-	// Each leaked connection attempt should leave connections open
-	// If there's a leak, we'd see growth proportional to iterations
-	// Without leak, growth should be zero or minimal
-	leakThreshold := int64(iterations * 2) // Allow some buffer
-
-	if connGrowth >= leakThreshold {
-		t.Logf("LEAK DETECTED: %d connections leaked over %d iterations", connGrowth, iterations)
-		t.Logf("This confirms the bug in PBM SDK's connect.MongoConnectWithOpts()")
-	}
-
-	// This test documents the leak. Once the PBM SDK is fixed, flip this assertion:
-	// assert.Less(t, connGrowth, leakThreshold, "Connection leak in PBM SDK")
-	assert.GreaterOrEqual(t, connGrowth, leakThreshold,
-		"Expected connection leak when Ping fails. Growth was %d, expected at least %d. "+
-			"If this fails, the PBM SDK may have been fixed!",
-		connGrowth, leakThreshold)
-}
-
-// getServerConnectionCount returns the current number of connections to the MongoDB server.
-func getServerConnectionCount(ctx context.Context, t *testing.T, client *mongo.Client) int64 {
-	t.Helper()
-
-	var result bson.M
-	err := client.Database("admin").RunCommand(ctx, bson.D{{Key: "serverStatus", Value: 1}}).Decode(&result)
-	require.NoError(t, err)
-
-	connections, ok := result["connections"].(bson.M)
-	require.True(t, ok, "serverStatus should contain connections field")
-
-	current, ok := connections["current"].(int32)
-	if ok {
-		return int64(current)
-	}
-
-	// Try int64 in case MongoDB returns it differently
-	current64, ok := connections["current"].(int64)
-	require.True(t, ok, "connections.current should be numeric")
-
-	return current64
-}