include tests and totalSum value

Author: idoqo

exporter/diagnostic_data_collector_test.go

@@ -29,10 +29,12 @@ import (
 	"github.com/pkg/errors"
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/testutil"
+	dto "github.com/prometheus/client_model/go"
 	"github.com/prometheus/common/promslog"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"go.mongodb.org/mongo-driver/bson"
+	"go.mongodb.org/mongo-driver/bson/primitive"
 	"go.mongodb.org/mongo-driver/mongo"
 
 	"github.com/percona/mongodb_exporter/internal/tu"
@@ -422,6 +424,95 @@ func addTestData(ctx context.Context, client *mongo.Client, count int) error {
 	return nil
 }
 
+func TestHistogramProcessing(t *testing.T) {
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
+	defer cancel()
+
+	client := tu.DefaultTestClient(ctx, t)
+	logger := promslog.New(&promslog.Config{})
+	ti := labelsGetterMock{}
+
+	dbBuildInfo, err := retrieveMongoDBBuildInfo(ctx, client, logger.With("component", "test"))
+	require.NoError(t, err)
+
+	c := newDiagnosticDataCollector(ctx, client, logger, true, ti, dbBuildInfo)
+
+	metrics := helpers.CollectMetrics(c)
+	metricFamilies := helpers.ReadMetrics(metrics)
+
+	// Check that histogram metrics are created instead of individual lowerBound/count metrics
+	histogramFound := false
+	duplicateMetrics := make(map[string]int)
+
+	for _, mf := range metricFamilies {
+		metricName := mf.String()
+
+		duplicateMetrics[metricName]++
+
+		if strings.Contains(metricName, "multiPlanner_histograms") &&
+			mf.Type == dto.MetricType_HISTOGRAM {
+			histogramFound = true
+		}
+
+		// Ensure no duplicate lowerBound/count metrics exist
+		if strings.Contains(metricName, "lowerBound") ||
+			(strings.Contains(metricName, "count") && strings.Contains(metricName, "histograms")) {
+			t.Errorf("Found individual histogram component metric: %s", metricName)
+		}
+	}
+
+	// Verify no duplicate metrics exist
+	for name, count := range duplicateMetrics {
+		if count > 0 {
+			t.Errorf("Duplicate metric found: %s (count: %d)", name, count)
+		}
+	}
+
+	// At least one histogram should be found if multiPlanner data exists
+	if histogramFound {
+		t.Logf("Successfully found histogram metrics")
+	}
+}
+
+func TestHistogramWithMockData(t *testing.T) {
+	// Test with controlled mock data to verify histogram creation
+	mockData := bson.M{
+		"multiPlanner": bson.M{
+			"classicMicros": bson.M{
+				"low":      int64(5000),
+				"high":     int64(0),
+				"unsigned": false,
+			},
+			"histograms": bson.M{
+				"classicMicros": primitive.A{
+					bson.M{
+						"lowerBound": bson.M{"low": int64(0), "high": int64(0), "unsigned": false},
+						"count":      bson.M{"low": int64(2), "high": int64(0), "unsigned": false},
+					},
+					bson.M{
+						"lowerBound": bson.M{"low": int64(1024), "high": int64(0), "unsigned": false},
+						"count":      bson.M{"low": int64(1), "high": int64(0), "unsigned": false},
+					},
+				},
+			},
+		},
+	}
+
+	labels := map[string]string{}
+	metrics := makeMetrics("", mockData, labels, true)
+
+	// Should have one histogram metric, not individual metrics
+	histogramCount := 0
+	for _, metric := range metrics {
+		desc := metric.Desc()
+		if strings.Contains(desc.String(), "multiPlanner_histograms_classicMicros") {
+			histogramCount++
+		}
+	}
+
+	require.Equal(t, 1, histogramCount, "Should create exactly one histogram metric")
+}
+
 func cleanTestData(ctx context.Context, client *mongo.Client, count int) error {
 	session, err := client.StartSession()
 	if err != nil {