Prevent duplicate collection and always run renaming/label logic

This change prevents running the replSetGetStatus or serverStatus
collectors if those data have been collected already via
getDiagnosticData.

Provide data from the replSetGetStatus and serverStatus collectors to
makeMetrics in a format such that the desired renames and label
management actions are carried out.

Note that this change is not backwards compatible for anyone running
with --collector.replicasetstatus as those metrics will now have a
prefix of mongodb_rs_ rather than just mongodb_

Author: trvrnrth

exporter/exporter.go

@@ -198,7 +198,9 @@ func (e *Exporter) makeRegistry(ctx context.Context, client *mongo.Client, topol
 		registry.MustRegister(ic)
 	}
 
-	if e.opts.EnableDiagnosticData && requestOpts.EnableDiagnosticData {
+	// getDiagnosticData does not return any data on mongos.
+	collectDiagnosticData := e.opts.EnableDiagnosticData && nodeType != typeMongos && requestOpts.EnableDiagnosticData
+	if collectDiagnosticData {
 		ddc := newDiagnosticDataCollector(ctx, client, e.opts.Logger,
 			e.opts.CompatibleMode, topologyInfo)
 		registry.MustRegister(ddc)
@@ -216,17 +218,20 @@ func (e *Exporter) makeRegistry(ctx context.Context, client *mongo.Client, topol
 		registry.MustRegister(tc)
 	}
 
-	// replSetGetStatus is not supported through mongos.
-	if e.opts.EnableReplicasetStatus && nodeType != typeMongos && requestOpts.EnableReplicasetStatus {
-		rsgsc := newReplicationSetStatusCollector(ctx, client, e.opts.Logger,
-			e.opts.CompatibleMode, topologyInfo)
-		registry.MustRegister(rsgsc)
-	}
+	// Only collect replica set and server status separately if we're not already fetching via diagnostic data
+	if !collectDiagnosticData {
+		// replSetGetStatus is not supported through mongos.
+		if e.opts.EnableReplicasetStatus && nodeType != typeMongos && requestOpts.EnableReplicasetStatus {
+			rsgsc := newReplicationSetStatusCollector(ctx, client, e.opts.Logger,
+				e.opts.CompatibleMode, topologyInfo)
+			registry.MustRegister(rsgsc)
+		}
 
-	if e.opts.EnableServerStatus {
-		ssc := newServerStatusCollector(ctx, client, e.opts.Logger,
-			e.opts.CompatibleMode, topologyInfo)
-		registry.MustRegister(ssc)
+		if e.opts.EnableServerStatus && requestOpts.EnableServerStatus {
+			ssc := newServerStatusCollector(ctx, client, e.opts.Logger,
+				e.opts.CompatibleMode, topologyInfo)
+			registry.MustRegister(ssc)
+		}
 	}
 
 	return registry

exporter/replset_status_collector.go

@@ -82,7 +82,7 @@ func (d *replSetGetStatusCollector) collect(ch chan<- prometheus.Metric) {
 	logger.Debug("replSetGetStatus result:")
 	debugResult(logger, m)
 
-	for _, metric := range makeMetrics("", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
+	for _, metric := range makeMetrics("", bson.M{"replSetGetStatus": m}, d.topologyInfo.baseLabels(), d.compatibleMode) {
 		ch <- metric
 	}
 }

exporter/serverstatus_collector.go

@@ -79,7 +79,7 @@ func (d *serverStatusCollector) collect(ch chan<- prometheus.Metric) {
 	logger.Debug("serverStatus result:")
 	debugResult(logger, m)
 
-	for _, metric := range makeMetrics("", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
+	for _, metric := range makeMetrics("", bson.M{"serverStatus": m}, d.topologyInfo.baseLabels(), d.compatibleMode) {
 		ch <- metric
 	}
 }