prevent mongos router from returning mongodb_mongod_replset_my_state (#1188)

* prevent mongos router from returning mongodb_mongod_replset_my_state

* chore: fix the compat version collector test

---------

Co-authored-by: Alex Demidoff <[email protected]>

Author: igroene

exporter/feature_compatibility_version_collector_test.go

@@ -50,17 +50,19 @@ func TestFCVCollector(t *testing.T) {
 	var mversion string
 
 	mmv := fmt.Sprintf("%d.%d", v.Segments()[0], v.Segments()[1])
-	switch {
-	case mmv == "5.0":
+	switch mmv {
+	case "5.0":
 		mversion = "4.4"
-	case mmv == "4.4":
+	case "4.4":
 		mversion = "4.2"
-	case mmv == "6.0":
+	case "6.0":
 		mversion = "5.0"
-	case mmv == "7.0":
+	case "7.0":
 		mversion = "6.0"
-	case mmv == "8.0":
+	case "8.0":
 		mversion = "7.0"
+	case "8.2":
+		mversion = "8.0"
 	default:
 		mversion = mmv
 	}

exporter/v1_compatibility.go

@@ -819,20 +819,18 @@ func specialMetrics(ctx context.Context, client *mongo.Client, m bson.M, nodeTyp
 		}
 	}
 
-	if nodeType != typeArbiter {
+	if nodeType == typeMongod {
 		metrics = append(metrics, myState(ctx, client))
 		if replSetGetStatus, ok := m["replSetGetStatus"].(bson.M); ok {
 			if rm := replSetMetrics(replSetGetStatus, l); rm != nil {
 				metrics = append(metrics, rm...)
 			}
 		}
 
-		if nodeType != typeMongos {
-			if opLogMetrics, err := oplogStatus(ctx, client); err != nil {
-				l.Warn("cannot create metrics for oplog", "error", err)
-			} else {
-				metrics = append(metrics, opLogMetrics...)
-			}
+		if opLogMetrics, err := oplogStatus(ctx, client); err != nil {
+			l.Warn("cannot create metrics for oplog", "error", err)
+		} else {
+			metrics = append(metrics, opLogMetrics...)
 		}
 	}