PMM-9320: fix auth creds (#497)

Author: ritbl

exporter/dsn_fix/dsn_fix.go

@@ -0,0 +1,43 @@
+// mongodb_exporter
+// Copyright (C) 2017 Percona LLC
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+package dsn_fix
+
+import (
+	"net/url"
+
+	"github.com/pkg/errors"
+	"go.mongodb.org/mongo-driver/mongo/options"
+)
+
+// ClientOptionsForDSN applies URI to Client.
+func ClientOptionsForDSN(dsn string) (*options.ClientOptions, error) {
+	clientOptions := options.Client().ApplyURI(dsn)
+
+	// Workaround for PMM-9320
+	// if username or password is set, need to replace it with correctly parsed credentials.
+	parsedDsn, err := url.Parse(dsn)
+	if err != nil {
+		return nil, errors.Wrap(err, "cannot parse DSN")
+	}
+	username := parsedDsn.User.Username()
+	password, _ := parsedDsn.User.Password()
+	if username != "" || password != "" {
+		clientOptions = clientOptions.SetAuth(options.Credential{Username: username, Password: password})
+	}
+
+	return clientOptions, nil
+}

exporter/dsn_fix/dsn_fix_test.go

@@ -0,0 +1,64 @@
+// mongodb_exporter
+// Copyright (C) 2017 Percona LLC
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+package dsn_fix
+
+import (
+	"net/url"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestClientOptionsForDSN(t *testing.T) {
+	tests := []struct {
+		name             string
+		dsn              string
+		expectedUser     string
+		expectedPassword string
+	}{
+		{
+			name: "Escape username",
+			dsn: (&url.URL{
+				Scheme: "mongo",
+				Host:   "localhost",
+				Path:   "/db",
+				User:   url.UserPassword("user+", "pass"),
+			}).String(),
+			expectedUser:     "user+",
+			expectedPassword: "pass",
+		},
+		{
+			name: "Escape password",
+			dsn: (&url.URL{
+				Scheme: "mongo",
+				Host:   "localhost",
+				Path:   "/db",
+				User:   url.UserPassword("user", "pass+"),
+			}).String(),
+			expectedUser:     "user",
+			expectedPassword: "pass+",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := ClientOptionsForDSN(tt.dsn)
+			assert.Nil(t, err)
+			assert.Equal(t, got.Auth.Username, tt.expectedUser)
+			assert.Equal(t, got.Auth.Password, tt.expectedPassword)
+		})
+	}
+}

exporter/exporter.go

@@ -33,7 +33,8 @@ import (
 	"github.com/prometheus/exporter-toolkit/web"
 	"github.com/sirupsen/logrus"
 	"go.mongodb.org/mongo-driver/mongo"
-	"go.mongodb.org/mongo-driver/mongo/options"
+
+	"github.com/percona/mongodb_exporter/exporter/dsn_fix"
 )
 
 // Exporter holds Exporter methods and attributes.
@@ -338,7 +339,10 @@ func (e *Exporter) Run() {
 }
 
 func connect(ctx context.Context, dsn string, directConnect bool) (*mongo.Client, error) {
-	clientOpts := options.Client().ApplyURI(dsn)
+	clientOpts, err := dsn_fix.ClientOptionsForDSN(dsn)
+	if err != nil {
+		return nil, fmt.Errorf("invalid dsn: %w", err)
+	}
 	clientOpts.SetDirect(directConnect)
 	clientOpts.SetAppName("mongodb_exporter")