Skip to content

Commit b4fffed

Browse files
committed
split test function to satisfy linter
1 parent 4168b9b commit b4fffed

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

exporter/exporter_test.go

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,9 @@ func TestMongoS(t *testing.T) {
199199
}
200200
}
201201

202-
func TestGSSAPIAuth(t *testing.T) {
203-
logger := logrus.New()
204-
logger.SetReportCaller(true)
205-
202+
func generateKerberosConfigFile(t *testing.T) (*os.File, error) {
206203
kerberosHost, err := tu.IpForContainer("kerberos")
207204
require.NoError(t, err)
208-
mongoHost, err := tu.IpForContainer("psmdb-kerberos")
209-
require.NoError(t, err)
210205

211206
config := fmt.Sprintf(`
212207
[libdefaults]
@@ -226,15 +221,27 @@ func TestGSSAPIAuth(t *testing.T) {
226221
perconatest.com = PERCONATEST.COM
227222
%s = PERCONATEST.COM
228223
`, kerberosHost, kerberosHost)
229-
230224
configFile, err := os.Create(t.TempDir() + "/krb5.conf")
231225
require.NoError(t, err)
226+
227+
_, err = configFile.WriteString(config)
228+
require.NoError(t, err)
229+
230+
return configFile, nil
231+
}
232+
func TestGSSAPIAuth(t *testing.T) {
233+
logger := logrus.New()
234+
logger.SetReportCaller(true)
235+
236+
mongoHost, err := tu.IpForContainer("psmdb-kerberos")
237+
require.NoError(t, err)
238+
239+
configFile, err := generateKerberosConfigFile(t)
240+
require.NoError(t, err)
232241
defer func() {
233242
_ = configFile.Close()
234243
_ = os.Setenv("KRB5_CONFIG", "")
235244
}()
236-
_, err = configFile.WriteString(config)
237-
require.NoError(t, err)
238245

239246
t.Setenv("KRB5_CONFIG", configFile.Name())
240247
ctx := context.Background()

internal/tu/testutils.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ func PortForContainer(name string) (string, error) {
199199
return ports[0].HostPort, nil
200200
}
201201

202+
// IpForContainer returns the IP address of a running container.
202203
func IpForContainer(name string) (string, error) {
203204
di, err := InspectContainer(name)
204205
if err != nil {

0 commit comments

Comments
 (0)