PMM-14431 More complex check if it is real count or not.

Author: JiriCtvrtka

exporter/collstats_collector.go

@@ -151,7 +151,7 @@ func (d *collstatsCollector) collect(ch chan<- prometheus.Metric) {
 				labels["shard"] = shard
 			}
 
-			for _, metric := range makeMetrics(prefix, metrics, labels, d.compatibleMode) {
+			for _, metric := range makeMetrics(client, prefix, metrics, labels, d.compatibleMode) {
 				ch <- metric
 			}
 		}

exporter/collstats_collector_test.go

@@ -26,10 +26,72 @@ import (
 	"github.com/prometheus/common/promslog"
 	"github.com/stretchr/testify/assert"
 	"go.mongodb.org/mongo-driver/bson"
+	"go.mongodb.org/mongo-driver/mongo"
+	"go.mongodb.org/mongo-driver/mongo/options"
 
 	"github.com/percona/mongodb_exporter/internal/tu"
 )
 
+func TestCollStatsCollectorAccountIndexes(t *testing.T) {
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
+	defer cancel()
+
+	client := tu.DefaultTestClient(ctx, t)
+
+	database := client.Database("testdb")
+	database.Drop(ctx) //nolint
+
+	defer func() {
+		err := database.Drop(ctx)
+		assert.NoError(t, err)
+	}()
+
+	collName := "test_collection_account"
+	coll := database.Collection(collName)
+
+	// Insert some data
+	_, err := coll.InsertOne(ctx, bson.M{"account_id": 1, "count": 10})
+	assert.NoError(t, err)
+	_, err = coll.InsertOne(ctx, bson.M{"account_id": 2, "count": 20})
+	assert.NoError(t, err)
+
+	// Create indexes
+	indexModel := mongo.IndexModel{
+		Keys:    bson.D{{Key: "account_id", Value: 1}},
+		Options: options.Index().SetName("test_index_account"),
+	}
+	_, err = coll.Indexes().CreateOne(ctx, indexModel)
+	assert.NoError(t, err)
+
+	indexModel = mongo.IndexModel{
+		Keys:    bson.D{{Key: "count", Value: 1}},
+		Options: options.Index().SetName("test_index_count"),
+	}
+	_, err = coll.Indexes().CreateOne(ctx, indexModel)
+	assert.NoError(t, err)
+
+	ti := labelsGetterMock{}
+
+	collection := []string{"testdb.test_collection_account"}
+	logger := promslog.New(&promslog.Config{})
+	c := newCollectionStatsCollector(ctx, client, logger, false, ti, collection, false)
+
+	// Expected metrics (simplified, adjust values as needed)
+	expected := strings.NewReader(`
+       # HELP mongodb_collstats_storageStats_indexSizes collstats.storageStats.indexSizes
+       # TYPE mongodb_collstats_storageStats_indexSizes untyped
+       mongodb_collstats_storageStats_indexSizes{collection="test_collection_account",database="testdb",index_name="_id_"} 4096
+       mongodb_collstats_storageStats_indexSizes{collection="test_collection_account",database="testdb",index_name="test_index_account"} 20480
+       mongodb_collstats_storageStats_indexSizes{collection="test_collection_account",database="testdb",index_name="test_index_count"} 20480
+       `)
+
+	filter := []string{
+		"mongodb_collstats_storageStats_indexSizes",
+	}
+	err = testutil.CollectAndCompare(c, expected, filter...)
+	assert.NoError(t, err)
+}
+
 func TestCollStatsCollector(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
 	defer cancel()

exporter/dbstats_collector.go

@@ -100,7 +100,7 @@ func (d *dbstatsCollector) collect(ch chan<- prometheus.Metric) {
 		// to differentiate metrics between different databases.
 		labels["database"] = db
 
-		newMetrics := makeMetrics(prefix, dbStats, labels, d.compatibleMode)
+		newMetrics := makeMetrics(client, prefix, dbStats, labels, d.compatibleMode)
 		for _, metric := range newMetrics {
 			ch <- metric
 		}

exporter/diagnostic_data_collector.go

@@ -126,7 +126,7 @@ func (d *diagnosticDataCollector) collect(ch chan<- prometheus.Metric) {
 			m = b
 		}
 
-		metrics = makeMetrics("", m, d.topologyInfo.baseLabels(), d.compatibleMode)
+		metrics = makeMetrics(client, "", m, d.topologyInfo.baseLabels(), d.compatibleMode)
 		metrics = append(metrics, locksMetrics(logger, m)...)
 
 		securityMetric, err := d.getSecurityMetricFromLineOptions(client)

exporter/indexstats_collector.go

@@ -137,7 +137,7 @@ func (d *indexstatsCollector) collect(ch chan<- prometheus.Metric) {
 			labels["key_name"] = indexName
 
 			metrics := sanitizeMetrics(metric)
-			for _, metric := range makeMetrics(prefix, metrics, labels, false) {
+			for _, metric := range makeMetrics(d.base.client, prefix, metrics, labels, false) {
 				ch <- metric
 			}
 		}

exporter/metrics.go

@@ -16,7 +16,10 @@
 package exporter
 
 import (
+	"context"
+	"fmt"
 	"regexp"
+	"slices"
 	"strings"
 	"sync"
 	"time"
@@ -25,6 +28,7 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 	"go.mongodb.org/mongo-driver/bson"
 	"go.mongodb.org/mongo-driver/bson/primitive"
+	"go.mongodb.org/mongo-driver/mongo"
 )
 
 const (
@@ -204,9 +208,58 @@ func nameAndLabel(prefix, name string) (string, string) {
 	return prometheusize(prefix + name), ""
 }
 
+func allReservedNames(client *mongo.Client) ([]string, error) {
+	ctx := context.Background()
+	reservedNames := []string{}
+	dbs, err := client.ListDatabaseNames(ctx, struct{}{})
+	if err != nil {
+		return reservedNames, err
+	}
+
+	for _, dbName := range dbs {
+		fmt.Printf("Database: %s\n", dbName)
+		db := client.Database(dbName)
+		collCursor, err := db.ListCollections(ctx, struct{}{})
+		if err != nil {
+			return reservedNames, err
+		}
+		defer collCursor.Close(ctx)
+		for collCursor.Next(ctx) {
+			var collInfo struct {
+				Name string `bson:"name"`
+				Type string `bson:"type"`
+			}
+			if err := collCursor.Decode(&collInfo); err != nil {
+				return reservedNames, err
+			}
+			reservedNames = append(reservedNames, collInfo.Name)
+			if collInfo.Type == "view" {
+				continue // skip views
+			}
+			coll := db.Collection(collInfo.Name)
+			cursor, err := coll.Indexes().List(ctx)
+			if err != nil {
+				continue // skip if cannot list indexes
+			}
+			defer cursor.Close(ctx)
+			for cursor.Next(ctx) {
+				var indexDoc map[string]interface{}
+				if err := cursor.Decode(&indexDoc); err != nil {
+					continue
+				}
+				if name, ok := indexDoc["name"].(string); ok {
+					reservedNames = append(reservedNames, name)
+				}
+			}
+		}
+	}
+
+	return reservedNames, nil
+}
+
 // makeRawMetric creates a Prometheus metric based on the parameters we collected by
 // traversing the MongoDB structures returned by the collector functions.
-func makeRawMetric(prefix, name string, value interface{}, labels map[string]string) (*rawMetric, error) {
+func makeRawMetric(reservedNames []string, prefix, name string, value interface{}, labels map[string]string) (*rawMetric, error) {
 	f, err := asFloat64(value)
 	if err != nil {
 		return nil, err
@@ -220,8 +273,10 @@ func makeRawMetric(prefix, name string, value interface{}, labels map[string]str
 	fqName, label := nameAndLabel(prefix, name)
 
 	metricType := prometheus.UntypedValue
-	if strings.HasSuffix(strings.ToLower(name), "count") {
-		metricType = prometheus.CounterValue
+	if !slices.Contains(reservedNames, name) {
+		if strings.HasSuffix(strings.ToLower(name), "count") {
+			metricType = prometheus.CounterValue
+		}
 	}
 
 	rm := &rawMetric{
@@ -301,7 +356,7 @@ func metricHelp(prefix, name string) string {
 	return name
 }
 
-func makeMetrics(prefix string, m bson.M, labels map[string]string, compatibleMode bool) []prometheus.Metric {
+func makeMetrics(client *mongo.Client, prefix string, m bson.M, labels map[string]string, compatibleMode bool) []prometheus.Metric {
 	var res []prometheus.Metric
 
 	if prefix != "" {
@@ -327,15 +382,21 @@ func makeMetrics(prefix string, m bson.M, labels map[string]string, compatibleMo
 		}
 		switch v := val.(type) {
 		case bson.M:
-			res = append(res, makeMetrics(nextPrefix, v, l, compatibleMode)...)
+			res = append(res, makeMetrics(client, nextPrefix, v, l, compatibleMode)...)
 		case map[string]interface{}:
-			res = append(res, makeMetrics(nextPrefix, v, l, compatibleMode)...)
+			res = append(res, makeMetrics(client, nextPrefix, v, l, compatibleMode)...)
 		case primitive.A:
-			res = append(res, processSlice(nextPrefix, v, l, compatibleMode)...)
+			res = append(res, processSlice(client, nextPrefix, v, l, compatibleMode)...)
 		case []interface{}:
 			continue
 		default:
-			rm, err := makeRawMetric(prefix, k, v, l)
+			reservedNames, err := allReservedNames(client)
+			if err != nil {
+				fmt.Printf("\n\n\n cannot get reserved names: %v \n\n\n", err)
+				continue
+			}
+
+			rm, err := makeRawMetric(reservedNames, prefix, k, v, l)
 			if err != nil {
 				invalidMetric := prometheus.NewInvalidMetric(prometheus.NewInvalidDesc(err), err)
 				res = append(res, invalidMetric)
@@ -376,7 +437,7 @@ func makeMetrics(prefix string, m bson.M, labels map[string]string, compatibleMo
 
 // Extract maps from arrays. Only some structures like replicasets have arrays of members
 // and each member is represented by a map[string]interface{}.
-func processSlice(prefix string, v []interface{}, commonLabels map[string]string, compatibleMode bool) []prometheus.Metric {
+func processSlice(client *mongo.Client, prefix string, v []interface{}, commonLabels map[string]string, compatibleMode bool) []prometheus.Metric {
 	metrics := make([]prometheus.Metric, 0)
 	labels := make(map[string]string)
 	for name, value := range commonLabels {
@@ -406,7 +467,7 @@ func processSlice(prefix string, v []interface{}, commonLabels map[string]string
 			labels["member_idx"] = host
 		}
 
-		metrics = append(metrics, makeMetrics(prefix, s, labels, compatibleMode)...)
+		metrics = append(metrics, makeMetrics(client, prefix, s, labels, compatibleMode)...)
 	}
 
 	return metrics

exporter/metrics_test.go

@@ -166,7 +166,7 @@ func TestMakeRawMetric(t *testing.T) {
 			}
 		}
 
-		m, err := makeRawMetric(prefix, name, tc.value, nil)
+		m, err := makeRawMetric(nil, prefix, name, tc.value, nil)
 
 		assert.NoError(t, err)
 		assert.Equal(t, want, m)

exporter/profile_status_collector.go

@@ -88,7 +88,7 @@ func (d *profileCollector) collect(ch chan<- prometheus.Metric) {
 		logger.Debug("profile response from MongoDB:")
 		debugResult(logger, primitive.M{db: m})
 
-		for _, metric := range makeMetrics("profile_slow_query", m, labels, d.compatibleMode) {
+		for _, metric := range makeMetrics(client, "profile_slow_query", m, labels, d.compatibleMode) {
 			ch <- metric
 		}
 	}

exporter/replset_config_collector.go

@@ -86,7 +86,7 @@ func (d *replSetGetConfigCollector) collect(ch chan<- prometheus.Metric) {
 	logger.Debug("replSetGetConfig result:")
 	debugResult(logger, m)
 
-	for _, metric := range makeMetrics("rs_cfg", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
+	for _, metric := range makeMetrics(client, "rs_cfg", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
 		ch <- metric
 	}
 }

exporter/replset_status_collector.go

@@ -81,7 +81,7 @@ func (d *replSetGetStatusCollector) collect(ch chan<- prometheus.Metric) {
 	logger.Debug("replSetGetStatus result:")
 	debugResult(logger, m)
 
-	for _, metric := range makeMetrics("", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
+	for _, metric := range makeMetrics(client, "", m, d.topologyInfo.baseLabels(), d.compatibleMode) {
 		ch <- metric
 	}
 }