You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[PMM-XXXX](https://jira.percona.com/browse/PMM-XXXX) (optional, if ticket reported)
2
2
3
-
-[ ] Links to other linked pull requests (optional).
3
+
-[ ] Links to related pull requests (optional).
4
4
5
5
---
6
6
7
-
-[ ] Tests passed.
8
-
-[ ] Fix conflicts with target branch.
9
-
-[ ] Update jira ticket description if needed.
10
-
-[ ] Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.
7
+
Below we provide a basic checklist of things that would make it a good PR:
8
+
- Make sure to sign the CLA (Contributor License Agreement).
9
+
- Make sure all tests pass.
10
+
- Keep current with the target branch and fix conflicts if necessary.
11
+
- Update jira ticket description if necessary.
12
+
- Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
13
+
- Leave notes to the reviewers if you need to focus their attention on something specific.
11
14
12
-
Once all checks pass and the code is ready for review, please add `pmm-review-exporters` team as the reviewer. That would assign people from the review team automatically. Report any issues on our [Forum](https://forums.percona.com) or [Discord](https://per.co.na/discord).
15
+
Once all checks pass and the code is ready for review, please add `pmm-review-exporters` team as the reviewer. That would assign people from the review team automatically. Report any issues on our [Forum](https://forums.percona.com).
0 commit comments