mongodb_mongod_wiredtiger_cache_max_bytes -> mongodb_ss_wt_cache_maximum_bytes_configured (oldName and newName) #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed mess with oldName and newName for mongodb_ss_wt_cache_maximum_bytes_configured
msotnikov
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
|
|
BupycHuk
approved these changes
Feb 5, 2025
Member
|
Hi, seems like this change made our tests failing. |
Contributor
Author
|
I tried to fix the test (blindly, as whole this PR). |
BupycHuk
reviewed
Feb 5, 2025
exporter/v1_compatibility.go
Outdated
Comment on lines
652
to
653
| oldName: "mongodb_ss_wt_cache_maximum_bytes_configured", | ||
| newName: "mongodb_mongod_wiredtiger_cache_max_bytes", | ||
| oldName: "mongodb_mongod_wiredtiger_cache_max_bytes", | ||
| newName: "mongodb_ss_wt_cache_maximum_bytes_configured", |
Member
There was a problem hiding this comment.
seems like we can remove these lines as we have the same at line 439.
Contributor
Author
There was a problem hiding this comment.
Looks like the reason of test fail was this duplicate. So I just removed extra rows and reverted any other changes
removed duplicate mongodb_ss_wt_cache_maximum_bytes_configured
BupycHuk
approved these changes
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 70.88% 65.72% -5.17%
==========================================
Files 28 28
Lines 3569 3034 -535
==========================================
- Hits 2530 1994 -536
- Misses 904 907 +3
+ Partials 135 133 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like they're mixed up.
Fixed mess with oldName and newName for mongodb_ss_wt_cache_maximum_bytes_configured