Commit d1a26a7
committed
DISTMYSQL-170: Orchestrator GUI: group multiple errantgtidstructure warning icons
https://jira.percona.com/browse/DISTMYSQL-170
Problem:
Warning icon is displayed for every cluster analysis problem detected.
If there is a lot of problems, a lot of warning icons in row is
displayed making GUI unreadable.
Solution:
Group 'warings', 'dangers', and 'muted' notifications, display small
number next to the icon indicating that grouping took place. Display
all warnings list when mouse pointer is hoofed over the icon.
Additionally fixed the way cluster analysis problems
(clustersAnalysisProblems map) were collected. When analysis entry
contained one or several structure analysis entries, adding them to
the array caused overwriting of all previously added entries.
It was because the loop always modified the same object's 'Analysis'
member instead of assigning structureAnalysis to the new object's
'Analysis' member.
Fixed by shallow cloning of the original object. Shallow copy is enough
because 'AnalyzedInstanceKey' can point to the same object.
Only what was pointed by 'Analysis' was problematic.1 parent eb84360 commit d1a26a7
2 files changed
+47
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| |||
112 | 114 | | |
113 | 115 | | |
114 | 116 | | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
120 | 127 | | |
121 | 128 | | |
122 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
123 | 137 | | |
124 | | - | |
125 | 138 | | |
126 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
127 | 157 | | |
128 | 158 | | |
129 | 159 | | |
| |||
0 commit comments