Skip to content

Commit d9dac04

Browse files
author
Yves Trudeau
committed
DISTMYSQL-364: Adding the detection of Percona server as candidate for Group replication topology instead of only Oracle MySQL. Modified also the comment above to better reflect conditions.
1 parent c0a82c7 commit d9dac04

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

go/inst/instance_dao.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -706,12 +706,13 @@ func ReadTopologyInstanceBufferable(instanceKey *InstanceKey, bufferWrites bool,
706706
if err != nil {
707707
goto Cleanup
708708
}
709-
// Populate GR information for the instance in Oracle MySQL 8.0+. To do this we need to wait for the Server UUID to
710-
// be populated to be able to find this instance's information in performance_schema.replication_group_members by
711-
// comparing UUIDs. We could instead resolve the MEMBER_HOST and MEMBER_PORT columns into an InstanceKey and compare
712-
// those instead, but this could require external calls for name resolving, whereas comparing UUIDs does not.
709+
// Populate GR information for the instance in Oracle MySQL 8.0+ or Percona Server 8.0+. To do this we need to wait
710+
// for the Server UUID to be populated to be able to find this instance's information in
711+
// performance_schema.replication_group_members by comparing UUIDs. We could instead resolve the MEMBER_HOST and
712+
// MEMBER_PORT columns into an InstanceKey and compare those instead, but this could require external calls for
713+
// name resolving, whereas comparing UUIDs does not.
713714
serverUuidWaitGroup.Wait()
714-
if instance.IsOracleMySQL() && !instance.IsSmallerMajorVersionByString("8.0") {
715+
if (instance.IsOracleMySQL() || instance.IsPercona()) && !instance.IsSmallerMajorVersionByString("8.0") {
715716
err := PopulateGroupReplicationInformation(instance, db)
716717
if err != nil {
717718
goto Cleanup

0 commit comments

Comments
 (0)