Skip to content

Commit e174de9

Browse files
committed
Address comments
1 parent fdbfe3b commit e174de9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ package_linux() {
227227
[ $do_rpm -eq 1 ] && fpm -v "${RELEASE_VERSION}" --epoch 1 -f -s dir -n orchestrator-client -m shlomi-noach --description "MySQL replication topology management and HA: client script" --url "https://github.com/openark/orchestrator" --vendor "GitHub" --license "Apache 2.0" -C $build_path/orchestrator-client --prefix=/ --depends 'jq >= 1.5' -t rpm .
228228
[ $do_deb -eq 1 ] && fpm -v "${RELEASE_VERSION}" --epoch 1 -f -s dir -n orchestrator-client -m shlomi-noach --description "MySQL replication topology management and HA: client script" --url "https://github.com/openark/orchestrator" --vendor "GitHub" --license "Apache 2.0" -C $build_path/orchestrator-client --prefix=/ --depends 'jq >= 1.5' -t deb --deb-no-default-config-files .
229229

230-
if [ ! -z "$package_name_extra" ] ; then
230+
if [ -n "$package_name_extra" ] ; then
231231
# Strip version core out of sting like "3.2.6-pre123+g1234567" to "3.2.6".
232232
# We need it because `-` is converted to `_` in rpm package name,
233233
# and `+` have a special meaning for `sed`.
@@ -281,7 +281,7 @@ main() {
281281
local build_only=$5
282282
local build_path
283283

284-
if [ "${RELEASE_VERSION}" == "" ] ; then
284+
if [ -z "${RELEASE_VERSION}" ] ; then
285285
RELEASE_VERSION=$(cat $basedir/RELEASE_VERSION)
286286
fi
287287
RELEASE_VERSION="${RELEASE_VERSION}${RELEASE_SUBVERSION}"

0 commit comments

Comments
 (0)