DISTMYSQL-423: Improve code formatting checks, adjust Docker images to use go-1.22.3

https://perconadev.atlassian.net/browse/DISTMYSQL-423

1. Use go-1.22.3 docker images
2. Improved code formatting check (handled the result)

Author: kamil-holubicki

docker/Dockerfile

@@ -14,7 +14,7 @@
 # ORC_USER (default: orc_server_user): username used to login to orchestrator backend MySQL server
 # ORC_PASSWORD (default: orc_server_password): password used to login to orchestrator backend MySQL server
 
-FROM golang:1.20.3-alpine3.17 as build
+FROM golang:1.22.3-alpine3.20 as build
 
 ENV GOPATH=/tmp/go
 
@@ -28,7 +28,7 @@ RUN rsync -av $(find /tmp/orchestrator-release -type d -name orchestrator -maxde
 RUN rsync -av $(find /tmp/orchestrator-release -type d -name orchestrator-client -maxdepth 2)/ /
 RUN cp conf/orchestrator-sample-sqlite.conf.json /etc/orchestrator.conf.json
 
-FROM alpine:3.17
+FROM alpine:3.20
 
 RUN apk --no-cache add bash curl jq
 

docker/Dockerfile.packaging

@@ -14,7 +14,7 @@
 # ORC_USER (default: orc_server_user): username used to login to orchestrator backend MySQL server
 # ORC_PASSWORD (default: orc_server_password): password used to login to orchestrator backend MySQL server
 
-FROM golang:1.20.3-bullseye
+FROM golang:1.22.3-bullseye
 
 RUN apt-get update
 RUN apt-get install -y ruby ruby-dev rubygems build-essential

docker/Dockerfile.raft

@@ -1,4 +1,4 @@
-FROM golang:1.20.3-bullseye
+FROM golang:1.22.3-bullseye
 LABEL maintainer="[email protected]"
 
 RUN apt-get update -q -y

docker/Dockerfile.system

@@ -1,4 +1,4 @@
-FROM golang:1.20.3-bullseye
+FROM golang:1.22.3-bullseye
 LABEL maintainer="[email protected]"
 
 ARG ci_env_repo="https://github.com/percona/orchestrator-ci-env.git"

docker/Dockerfile.test

@@ -1,4 +1,4 @@
-FROM golang:1.20.3-bullseye
+FROM golang:1.22.3-bullseye
 LABEL maintainer="[email protected]"
 
 RUN apt-get update

script/test-source

@@ -4,6 +4,13 @@ validate_source_code_conventions() {
   echo "# Verifying code is formatted via 'gofmt -s -w  go/'"
   gofmt -s -w  go/
   git diff --exit-code --quiet go/
+  if [[ $? -ne 0 ]]; then
+    # Echo the message containing + FAIL string to allow Jenkins script to catch the failure.
+    echo "Code formatting check result: + FAIL"
+    git diff go/
+    exit 1    
+  fi
+  echo "Code formatting check result: PASSED"
 }
 
 validate_source_code_conventions