PBM-1294 selective logical backup/restore with Users & Roles#337
PBM-1294 selective logical backup/restore with Users & Roles#337rasika-chivate wants to merge 41 commits intomainfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jcechace
left a comment
There was a problem hiding this comment.
LGTM. Few things
- consider explicitly mentionn that
--with-users-and-rolesrequires a collection wildcard (so--ns='test.*'is ok, but--ns='test.col'is not - describe when
--with-users-and-rolesis required forpbm restore(in general only if--nsis used) see percona/percona-backup-mongodb#1260
But these are just options
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #### Overview | ||
|
|
||
| Percona Backup for MongoDB allows you to perform selective restore of databases and collections. Additionally, you can choose to include **users and roles defined** in the database in your selective backup, ensuring that access control is restored along with the data. |
There was a problem hiding this comment.
This is in the restore section, but it says 'include ... in your selective backup'. Suggest rewording to 'include ... in your selective restore' (or 'restore users and roles alongside the data') to avoid confusion.
| Percona Backup for MongoDB allows you to perform selective restore of databases and collections. Additionally, you can choose to include **users and roles defined** in the database in your selective backup, ensuring that access control is restored along with the data. | |
| Percona Backup for MongoDB allows you to perform selective restore of databases and collections. Additionally, you can choose to include **users and roles defined** in the database in your selective restore, ensuring that access control is restored along with the data. |
|
|
||
| Percona Backup for MongoDB enables you to perform selective backups of databases and collections. Also, you can choose to include **users and roles defined** in the database in your selective backup, ensuring that access control is restored along with the data. | ||
|
|
||
| To back up a specific namespace and include users and roles, run the following command: |
There was a problem hiding this comment.
The restore page documents important constraints for --with-users-and-roles (e.g., requiring a collection wildcard like mydb.*, excluding cluster/global users/roles, and overwrite behavior on restore). This backup page currently doesn’t call out the wildcard requirement or explicitly clarify the same scope limitation (db-scoped only). Suggest adding a short warning/note here for consistency so users don’t try --ns=\"db.collection\" or assume cluster-wide users/roles are included.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Provide a detailed documentation of the command used for selective backup and restore. Include instructions on how to optionally include related users and roles in the backup and restoration process. Ensure that all syntax, parameters, and examples are clearly explained.
Refer to the ticket PBM-1294 for more information.