Add validation for fallback & allowPartlyDone opts

Author: boris-ilijic

cmd/pbm/main.go

@@ -822,6 +822,7 @@ func (app *pbmApp) buildRestoreCmd() *cobra.Command {
 	restoreCmd.Flags().Bool(
 		"allow-partly-done", false,
 		"Allows parly done state of the cluster after physical restore. "+
+			"If enabled (default), partly-done status for RS will be treated as successful restore."+
 			"If disabled, fallback will be applied when cluster is partly-done.",
 	)
 

cmd/pbm/restore.go

@@ -141,6 +141,9 @@ func runRestore(
 	if err := validateRestoreUsersAndRoles(o.usersAndRoles, nss); err != nil {
 		return nil, errors.Wrap(err, "parse --with-users-and-roles option")
 	}
+	if err := validateFallbackOpts(o); err != nil {
+		return nil, err
+	}
 
 	rsMap, err := parseRSNamesMapping(o.rsMap)
 	if err != nil {
@@ -816,6 +819,15 @@ func validateNSFromNSTo(o *restoreOpts) error {
 	return nil
 }
 
+func validateFallbackOpts(o *restoreOpts) error {
+	if o.fallback != nil && !*o.fallback &&
+		o.allowPartlyDone != nil && !*o.allowPartlyDone {
+		return errors.New("It's not possible to disable both --allow-partly-done " +
+			"and --fallback-enabled at the same time.")
+	}
+	return nil
+}
+
 func parseCLINumInsertionWorkersOption(value int32) (*int32, error) {
 	if value < 0 {
 		return nil, errors.New("Number of insertion workers has to be greater than zero.")

pbm/restore/physical.go

@@ -2567,6 +2567,9 @@ func (r *PhysRestore) prepareBackup(ctx context.Context, backupName string) erro
 			return errors.Wrap(err, "check disk space")
 		}
 	}
+	if !r.fallback && !r.allowPartlyDone {
+		return errors.New("fallbackEnabled and allowPartlyDone cannot be disabled at the same time")
+	}
 
 	s, err := topo.ClusterMembers(ctx, r.leadConn.MongoClient())
 	if err != nil {