PBM-1229: skip waitForStatus on the backup leader

the leader only sets the status. no reason to wait for known condition

Author: defbin

pbm/backup/backup.go

@@ -348,14 +348,12 @@ func (b *Backup) Run(ctx context.Context, bcp *ctrl.BackupCmd, opid ctrl.OPID, l
 		}
 
 		err = writeMeta(stg, bcpm)
-		if err != nil {
-			return errors.Wrap(err, "dump metadata")
-		}
+		return errors.Wrap(err, "dump metadata")
+	} else {
+		// to be sure the locks released only after the "done" status had written
+		err = b.waitForStatus(ctx, bcp.Name, defs.StatusDone, nil)
+		return errors.Wrap(err, "waiting for done")
 	}
-
-	// to be sure the locks released only after the "done" status had written
-	err = b.waitForStatus(ctx, bcp.Name, defs.StatusDone, nil)
-	return errors.Wrap(err, "waiting for done")
 }
 
 func waitForBalancerOff(ctx context.Context, conn connect.Client, t time.Duration, l log.LogEvent) topo.BalancerMode {
@@ -412,11 +410,11 @@ func (b *Backup) toState(
 			}
 			return errors.Wrapf(err, "check cluster for backup `%s`", status)
 		}
-	}
-
-	err = b.waitForStatus(ctx, bcp, status, wait)
-	if err != nil {
-		return errors.Wrapf(err, "waiting for %s", status)
+	} else {
+		err = b.waitForStatus(ctx, bcp, status, wait)
+		if err != nil {
+			return errors.Wrapf(err, "waiting for %s", status)
+		}
 	}
 
 	return nil

pbm/backup/logical.go

@@ -81,16 +81,18 @@ func (b *Backup) doLogical(
 			return errors.Wrap(err, "check cluster for backup started")
 		}
 
+		// TODO(improve): do setClusterFirstWrite between
+		// all replsets status are StatusRunning and setting the global status
 		err = b.setClusterFirstWrite(ctx, bcp.Name)
 		if err != nil {
 			return errors.Wrap(err, "set cluster first write ts")
 		}
-	}
-
-	// Waiting for cluster's StatusRunning to move further.
-	err = b.waitForStatus(ctx, bcp.Name, defs.StatusRunning, nil)
-	if err != nil {
-		return errors.Wrap(err, "waiting for running")
+	} else {
+		// Waiting for cluster's StatusRunning to move further.
+		err = b.waitForStatus(ctx, bcp.Name, defs.StatusRunning, nil)
+		if err != nil {
+			return errors.Wrap(err, "waiting for running")
+		}
 	}
 
 	stopOplogSlicer := startOplogSlicer(ctx,
@@ -195,11 +197,11 @@ func (b *Backup) doLogical(
 		if err != nil {
 			return errors.Wrap(err, "check cluster for dump done")
 		}
-	}
-
-	err = b.waitForStatus(ctx, bcp.Name, defs.StatusDumpDone, nil)
-	if err != nil {
-		return errors.Wrap(err, "waiting for dump done")
+	} else {
+		err = b.waitForStatus(ctx, bcp.Name, defs.StatusDumpDone, nil)
+		if err != nil {
+			return errors.Wrap(err, "waiting for dump done")
+		}
 	}
 
 	lastSavedTS, oplogSize, err := stopOplogSlicer()

pbm/backup/physical.go

@@ -330,12 +330,12 @@ func (b *Backup) doPhysical(
 		if err != nil {
 			return errors.Wrap(err, "set cluster last write ts")
 		}
-	}
-
-	// Waiting for cluster's StatusRunning to move further.
-	err = b.waitForStatus(ctx, bcp.Name, defs.StatusRunning, nil)
-	if err != nil {
-		return errors.Wrap(err, "waiting for running")
+	} else {
+		// Waiting for cluster's StatusRunning to move further.
+		err = b.waitForStatus(ctx, bcp.Name, defs.StatusRunning, nil)
+		if err != nil {
+			return errors.Wrap(err, "waiting for running")
+		}
 	}
 
 	_, lwTS, err := b.waitForFirstLastWrite(ctx, bcp.Name)