PBM-1473 - Improve PBM behavior when the log.path option is modified in the configuration file (#1079)

* rename function

* remove option to change path

Author: veceraj

cmd/pbm-agent/main.go

@@ -207,7 +207,7 @@ func runAgent(
 	defer logger.Close()
 
 	viper.OnConfigChange(func(e fsnotify.Event) {
-		logger.SetOpts(buildLogOpts())
+		logger.SetLogLevelAndJSON(buildLogOpts())
 		newOpts := logger.Opts()
 		logger.Printf("log options updated: log-path=%s, log-level:%s, log-json:%t",
 			newOpts.LogPath, newOpts.LogLevel, newOpts.LogJSON)

pbm/log/discard.go

@@ -56,7 +56,7 @@ func (discardLoggerImpl) Output(ctx context.Context, e *Entry) error {
 
 func (discardLoggerImpl) Opts() *Opts { return nil }
 
-func (discardLoggerImpl) SetOpts(cfg *Opts) {
+func (discardLoggerImpl) SetLogLevelAndJSON(cfg *Opts) {
 }
 
 type discardEventImpl struct{}

pbm/log/log.go

@@ -36,7 +36,7 @@ type Logger interface {
 	Fatal(event, obj, opid string, epoch primitive.Timestamp, msg string, args ...any)
 	Output(ctx context.Context, e *Entry) error
 	Opts() *Opts
-	SetOpts(cfg *Opts)
+	SetLogLevelAndJSON(cfg *Opts)
 }
 
 type LogEvent interface {

pbm/log/logger.go

@@ -314,17 +314,14 @@ func (l *loggerImpl) Opts() *Opts {
 	}
 }
 
-func (l *loggerImpl) SetOpts(cfg *Opts) {
+func (l *loggerImpl) SetLogLevelAndJSON(cfg *Opts) {
 	if cfg == nil {
 		return
 	}
 
 	l.mu.Lock()
 	defer l.mu.Unlock()
 
-	if cfg.LogPath != "" && l.logger.logPath != cfg.LogPath {
-		l.createLogger(cfg.LogPath)
-	}
 	if cfg.LogLevel != "" && l.logLevel.String() != cfg.LogLevel {
 		l.logLevel = strToSeverity(cfg.LogLevel)
 	}