PBM-1414 add unit test and add some small refactor for easier troubleshooting

Author: radoslawszulgo

cmd/pbm/restore.go

@@ -358,12 +358,12 @@ func nsIsTaken(
 	ns string,
 ) error {
 	ns = strings.TrimSpace(ns)
-	db, coll, ok := strings.Cut(ns, ".")
+	dbName, coll, ok := strings.Cut(ns, ".")
 	if !ok {
 		return errors.Wrap(ErrInvalidNamespace, ns)
 	}
 
-	collNames, err := conn.MongoClient().Database(db).ListCollectionNames(ctx, bson.D{{"name", coll}})
+	collNames, err := conn.MongoClient().Database(dbName).ListCollectionNames(ctx, bson.D{{"name", coll}})
 	if err != nil {
 		return errors.Wrap(err, "list collection names for cloning target validation")
 	}

cmd/pbm/restore_test.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"errors"
+	"reflect"
 	"testing"
 )
 
@@ -110,3 +111,56 @@ func TestCloningValidation(t *testing.T) {
 		})
 	}
 }
+
+func Test_parseCLINumInsertionWorkersOption(t *testing.T) {
+
+	type args struct {
+		value int32
+	}
+
+	var num int32 = 1
+
+	tests := []struct {
+		name    string
+		args    args
+		want    *int32
+		wantErr bool
+	}{
+		{
+			name: "valid number - no error",
+			args: args{
+				value: 1,
+			},
+			want:    &num,
+			wantErr: false,
+		},
+		{
+			name: "zero  - no error, but return nil",
+			args: args{
+				value: 0,
+			},
+			want:    nil,
+			wantErr: false,
+		},
+		{
+			name: "negative value  - error",
+			args: args{
+				value: -1,
+			},
+			want:    nil,
+			wantErr: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := parseCLINumInsertionWorkersOption(tt.args.value)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("parseCLINumInsertionWorkersOption() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("parseCLINumInsertionWorkersOption() got = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

pbm/config/config.go

@@ -554,7 +554,7 @@ func confSetPITR(ctx context.Context, m connect.Client, value bool) error {
 // GetConfigVar returns value of given config vaiable
 func GetConfigVar(ctx context.Context, m connect.Client, key string) (interface{}, error) {
 	if !validateConfigKey(key) {
-		return nil, errors.New("invalid config key")
+		return nil, errors.Errorf("invalid config key: %s", key)
 	}
 
 	bts, err := m.ConfigCollection().

pbm/topo/cluster.go

@@ -2,6 +2,8 @@ package topo
 
 import (
 	"context"
+	"encoding/json"
+	"fmt"
 	"strings"
 
 	"go.mongodb.org/mongo-driver/bson"
@@ -58,7 +60,13 @@ func GetClusterTime(ctx context.Context, m connect.Client) (primitive.Timestamp,
 
 func ClusterTimeFromNodeInfo(info *NodeInfo) (primitive.Timestamp, error) {
 	if info.ClusterTime == nil {
-		return primitive.Timestamp{}, errors.New("no clusterTime in response")
+		jsonResponse, err := json.Marshal(info)
+		errDetails := string(jsonResponse)
+		if err != nil {
+			fmt.Println(err)
+			errDetails = "Unable to parse response."
+		}
+		return primitive.Timestamp{}, errors.Errorf("No clusterTime in response. Received: %s", errDetails)
 	}
 
 	return info.ClusterTime.ClusterTime, nil