Add option to disable logger during saving to S3

During physical restore logger data are stored on the storage. Therefore
logging during S3 Save opration is not the option, the logging buffer
will get full and will cause deadlock.

This commit adds option for S3.Save method to dissable logger.
During physical restore logBuffer implementation uses that option to
dissable logger during Save just when logBuffer does writes to the
storage.

Author: boris-ilijic

pbm/restore/physical.go

@@ -987,7 +987,9 @@ func (r *PhysRestore) Snapshot(
 		buf:   &bytes.Buffer{},
 		path:  fmt.Sprintf("%s/%s/rs.%s/log/%s", defs.PhysRestoresDir, r.name, r.rsConf.ID, r.nodeInfo.Me),
 		limit: 1 << 20, // 1Mb
-		write: func(name string, data io.Reader) error { return r.stg.Save(name, data, -1) },
+		write: func(name string, data io.Reader) error {
+			return r.stg.Save(name, data, -1, storage.UseLogger(false))
+		},
 	})
 	logger.PauseMgo()
 

pbm/storage/s3/s3.go

@@ -315,6 +315,12 @@ func (*S3) Type() storage.Type {
 }
 
 func (s *S3) Save(name string, data io.Reader, sizeb int64, options ...storage.Option) error {
+	opts := storage.GetDefaultOpts()
+	for _, opt := range options {
+		if err := opt(opts); err != nil {
+			return errors.Wrap(err, "processing options for save")
+		}
+	}
 	cc := runtime.NumCPU() / 2
 	if cc == 0 {
 		cc = 1
@@ -367,7 +373,7 @@ func (s *S3) Save(name string, data io.Reader, sizeb int64, options ...storage.O
 		}
 	}
 
-	if s.log != nil {
+	if s.log != nil && opts.UseLogger {
 		s.log.Debug("uploading %q [size hint: %v (%v); part size: %v (%v)]",
 			name,
 			sizeb,