Fix flaky unit test when waiting for free port

boris-ilijic · boris-ilijic · commit fa8015f1a8c3 · 2025-05-23T12:30:26.000+02:00
Adding more waiting time should make it stabile.
diff --git a/pbm/restore/physical_test.go b/pbm/restore/physical_test.go
@@ -203,7 +203,7 @@ func TestWaitMgoFreePort(t *testing.T) {
 			t.Fatalf("error while waiting for the free port: %v", err)
 		}
 		if duration < portUsed-time.Second ||
-			duration > portUsed+time.Second {
+			duration > portUsed+2*time.Second {
 			t.Fatalf("wrong duration time, want~=%v, got=%v", portUsed, duration)
 		}
 	})

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ func TestWaitMgoFreePort(t *testing.T) {`
`203`	`203`	`t.Fatalf("error while waiting for the free port: %v", err)`
`204`	`204`	`}`
`205`	`205`	`if duration < portUsed-time.Second \|\|`
`206`		`- duration > portUsed+time.Second {`
	`206`	`+ duration > portUsed+2*time.Second {`
`207`	`207`	`t.Fatalf("wrong duration time, want~=%v, got=%v", portUsed, duration)`
`208`	`208`	`}`
`209`	`209`	`})`