Add completion scripts to deb and rpm packages #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veceraj
approved these changes
Jun 27, 2025
boris-ilijic
approved these changes
Jun 30, 2025
|
Since we haven't merged this yet, @sandraromanchenko / @olexandr-havryliak please review it so that we can proceed. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds shell completion scripts for bash and zsh to both DEB and RPM packages, enabling tab completion for the pbm commands. The changes ensure completion files are included in package builds and properly installed to standard system locations.
Key Changes
- Modified build process to include completion script generation
- Added completion file installation to RPM spec file with proper permissions
- Updated Debian packaging to install completion scripts to appropriate system directories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packaging/rpm/mongodb-backup.spec | Adds installation of bash and zsh completion files to RPM package with proper directory creation and file permissions |
| packaging/debian/rules | Creates completion directories and copies completion files during Debian package build process |
| packaging/debian/install | Specifies installation paths for completion files in Debian package to standard system locations |
| Makefile | Updates build-all target to include completion script generation |
Comments suppressed due to low confidence (1)
packaging/debian/rules:66
- This line appears to be accidentally removed (shown with a '-' prefix in the diff). The pbm-agent-entrypoint binary should still be copied to maintain package completeness.
cd build/src/github.com/percona/percona-backup-mongodb/bin && cp completions/bash/pbm-agent $(TMP)/completions/bash/pbm-agent
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.