PCSM-219: Remove unnecessary Viper wrappers

- Remove getPort() wrapper, use viper.GetInt("port") directly
- Remove unused GetString, GetInt, GetBool, IsSet wrappers from config/config.go
- These wrappers added no value (pure pass-through with no added logic)

Author: chupe

config/config.go

@@ -65,23 +65,3 @@ func bindEnvVars() {
 	// Bulk write option (hidden, internal use)
 	_ = viper.BindEnv("use-collection-bulk-write", "PCSM_USE_COLLECTION_BULK_WRITE")
 }
-
-// GetString returns a string configuration value from Viper.
-func GetString(key string) string {
-	return viper.GetString(key)
-}
-
-// GetInt returns an integer configuration value from Viper.
-func GetInt(key string) int {
-	return viper.GetInt(key)
-}
-
-// GetBool returns a boolean configuration value from Viper.
-func GetBool(key string) bool {
-	return viper.GetBool(key)
-}
-
-// IsSet checks if a configuration key has been set.
-func IsSet(key string) bool {
-	return viper.IsSet(key)
-}

main.go

@@ -86,7 +86,7 @@ var rootCmd = &cobra.Command{
 			return nil
 		}
 
-		port := getPort()
+		port := viper.GetInt("port")
 
 		// Use Viper to get source/target URIs (supports CLI flags and env vars)
 		sourceURI := viper.GetString("source")
@@ -147,9 +147,7 @@ var statusCmd = &cobra.Command{
 	Use:   "status",
 	Short: "Get the status of the replication process",
 	RunE: func(cmd *cobra.Command, _ []string) error {
-		port := getPort()
-
-		return NewClient(port).Status(cmd.Context())
+		return NewClient(viper.GetInt("port")).Status(cmd.Context())
 	},
 }
 
@@ -158,8 +156,6 @@ var startCmd = &cobra.Command{
 	Use:   "start",
 	Short: "Start Cluster Replication",
 	RunE: func(cmd *cobra.Command, _ []string) error {
-		port := getPort()
-
 		pauseOnInitialSync, _ := cmd.Flags().GetBool("pause-on-initial-sync")
 		includeNamespaces, _ := cmd.Flags().GetStringSlice("include-namespaces")
 		excludeNamespaces, _ := cmd.Flags().GetStringSlice("exclude-namespaces")
@@ -170,7 +166,7 @@ var startCmd = &cobra.Command{
 			ExcludeNamespaces:  excludeNamespaces,
 		}
 
-		return NewClient(port).Start(cmd.Context(), startOptions)
+		return NewClient(viper.GetInt("port")).Start(cmd.Context(), startOptions)
 	},
 }
 
@@ -179,15 +175,13 @@ var finalizeCmd = &cobra.Command{
 	Use:   "finalize",
 	Short: "Finalize Cluster Replication",
 	RunE: func(cmd *cobra.Command, _ []string) error {
-		port := getPort()
-
 		ignoreHistoryLost, _ := cmd.Flags().GetBool("ignore-history-lost")
 
 		finalizeOptions := finalizeRequest{
 			IgnoreHistoryLost: ignoreHistoryLost,
 		}
 
-		return NewClient(port).Finalize(cmd.Context(), finalizeOptions)
+		return NewClient(viper.GetInt("port")).Finalize(cmd.Context(), finalizeOptions)
 	},
 }
 
@@ -196,9 +190,7 @@ var pauseCmd = &cobra.Command{
 	Use:   "pause",
 	Short: "Pause Cluster Replication",
 	RunE: func(cmd *cobra.Command, _ []string) error {
-		port := getPort()
-
-		return NewClient(port).Pause(cmd.Context())
+		return NewClient(viper.GetInt("port")).Pause(cmd.Context())
 	},
 }
 
@@ -207,15 +199,13 @@ var resumeCmd = &cobra.Command{
 	Use:   "resume",
 	Short: "Resume Cluster Replication",
 	RunE: func(cmd *cobra.Command, _ []string) error {
-		port := getPort()
-
 		fromFailure, _ := cmd.Flags().GetBool("from-failure")
 
 		resumeOptions := resumeRequest{
 			FromFailure: fromFailure,
 		}
 
-		return NewClient(port).Resume(cmd.Context(), resumeOptions)
+		return NewClient(viper.GetInt("port")).Resume(cmd.Context(), resumeOptions)
 	},
 }
 
@@ -312,12 +302,6 @@ var resetHeartbeatCmd = &cobra.Command{
 	},
 }
 
-// getPort returns the port number from Viper configuration.
-// Viper handles precedence: CLI flag > env var (PCSM_PORT) > default.
-func getPort() int {
-	return viper.GetInt("port")
-}
-
 func main() {
 	rootCmd.PersistentFlags().String("log-level", "info", "Log level")
 	rootCmd.PersistentFlags().Bool("log-json", false, "Output log in JSON format")