dont stop watcher, gate the logic and continue

Author: gkech

percona/controller/pgcluster/controller.go

@@ -978,6 +978,8 @@ func (r *PGClusterReconciler) reconcileExternalWatchers(ctx context.Context, cr
 }
 
 func (r *PGClusterReconciler) startExternalWatchers(ctx context.Context, cr *v2.PerconaPGCluster) error {
+	log := logging.FromContext(ctx)
+
 	if !cr.Spec.Backups.IsEnabled() {
 		return nil
 	}
@@ -986,8 +988,6 @@ func (r *PGClusterReconciler) startExternalWatchers(ctx context.Context, cr *v2.
 		return nil
 	}
 
-	log := logging.FromContext(ctx)
-
 	watcherName, watcherFunc := watcher.GetWALWatcher(cr)
 	if r.Watchers.IsExist(watcherName) {
 		return nil

percona/watcher/wal.go

@@ -56,8 +56,6 @@ func WatchCommitTimestamps(ctx context.Context, cli client.Client, eventChan cha
 	for {
 		select {
 		case <-ticker.C:
-			log.V(1).Info("Running WAL watcher")
-
 			localCr := cr.DeepCopy()
 			err := cli.Get(ctx, client.ObjectKeyFromObject(cr), localCr)
 			if err != nil {
@@ -66,9 +64,9 @@ func WatchCommitTimestamps(ctx context.Context, cli client.Client, eventChan cha
 			}
 
 			if !localCr.Spec.Backups.IsEnabled() {
-				log.Info("Backups are disabled, stopping WAL watcher")
-				return
+				continue
 			}
+			log.V(1).Info("Running WAL watcher")
 
 			latestBackup, err := getLatestBackup(ctx, cli, localCr)
 			if err != nil {